Maniphest T363948

[S] Image recommendations - API improvements
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tsevener
	Wed, May 1, 9:52 PM

Tags

Referenced Files

None

Subscribers

Description

Because the image recommendations call takes a while, we should ensure we are only fetching them if we already know the user qualifies (logged in, 50+ edits, not blocked). This will make the app more efficient and reduce server load. Currently we are making the image recommendations call for everyone, but hiding the card if they don't qualify.
Sometimes image recommendations returned actually do have an article image. We should filter out recommendations against the pageimages MediaWiki API property to confirm there is no existing image for that article. (Background: https://wikimedia.slack.com/archives/CEKKLRDT2/p1714584170403229)

Testing Notes

Please regression test Explore feed suggested edits card appearance, and confirm there are no image suggestions for articles that already have an image.

Event Timeline

Tsevener created this task.Wed, May 1, 9:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, May 1, 9:52 PM

https://github.com/wikimedia/wikipedia-ios/pull/4830

Tsevener claimed this task.Wed, May 1, 9:53 PM

Tsevener renamed this task from Image recommendations - API improvements to [S] Image recommendations - API improvements.Wed, May 1, 9:56 PM

mazevedofs closed https://github.com/wikimedia/wikipedia-ios/pull/4830

Mazevedo moved this task from Needs Code Review to Needs QA on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.Thu, May 2, 7:59 AM

Mazevedo moved this task from Needs QA to Waiting for Build on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.Thu, May 2, 8:06 AM

Can be tested in Wikipedia 7.5.0 (3546)

Tsevener removed Tsevener as the assignee of this task.Thu, May 2, 2:53 PM

Tsevener updated the task description. (Show Details)

Looks good on 7.5.0 (3550)

HNordeenWMF moved this task from Ready for PM Signoff to Ready for Release on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.Thu, May 2, 9:57 PM

HNordeenWMF closed this task as Unknown Status.Tue, May 7, 3:42 PM

HNordeenWMF claimed this task.

HNordeenWMF changed the task status from Unknown Status to Resolved.Tue, May 7, 10:17 PM