Page MenuHomePhabricator

Table: Fix border when caption is hidden and vertical borders are enabled
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

There's a double border at the top of the table.

Screenshot 2024-05-15 at 8.52.03 AM.png (1×1 px, 170 KB)

What should have happened instead?:

There should be a single @border-color-base border at the top.

Software version: Codex 1.6.0

Event Timeline

Change #1032552 had a related patch set uploaded (by LWatson; author: LWatson):

[design/codex@main] Table: Fix border when caption is hidden and vertical borders are enabled

https://gerrit.wikimedia.org/r/1032552

lwatson changed the task status from Open to In Progress.May 16 2024, 7:08 PM

Change #1032552 merged by jenkins-bot:

[design/codex@main] Table: fix border when hidden caption and vertical borders are enabled

https://gerrit.wikimedia.org/r/1032552

Design verification done 🎉 This looks equally fantastic across browsers (Chrome 125, Safari 17.3, Firefox 126.0)

Change #1037103 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update Codex from v1.6.0 to v1.6.1

https://gerrit.wikimedia.org/r/1037103

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/ce0a74a0e6/w

Change #1037103 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.6.0 to v1.6.1

https://gerrit.wikimedia.org/r/1037103

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/ce0a74a0e6/w/