Page MenuHomePhabricator

Remove Mobile special page code for change lists
Closed, ResolvedPublic1 Estimated Story Points

Description

Background

After several years of slow effort we have now replaced the mobile versions of Watchlist, History, Contributions without the desktop HTML. We can now remove > 1000 lines of code.

User story

As a developer I don't want to be confused by code that doesn't do anything.

Acceptance criteria

as the last page that is using it

  • Fold MobileUI functionality into SpecialMobileOptions as the last

page that is using it

  • Hook MobileSpecialPageStyles is removed without deprecation

as it is not used anywhere

  • Rename test to MobileSpecialMobileDiffTest since it tests

the MobileDiff page

Communication criteria - does this need an announcement or discussion?

No communication necessary.

Rollback plan

This code is not enabled anywhere so should not be doing anything. It is safe to revert if unexpected errors occur in production.

This task was created by Version 1.0.0 of the Web team task template using phabulous

Event Timeline

Jdlrobson triaged this task as Medium priority.May 23 2024, 10:28 PM
Jdlrobson set the point value for this task to 1.

Change #1034590 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Dismantle Special:Watchlist and associated code

https://gerrit.wikimedia.org/r/1034590

Jdlrobson raised the priority of this task from Medium to High.May 31 2024, 8:08 PM

Change #1034590 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Dismantle Special:Watchlist and associated code

https://gerrit.wikimedia.org/r/1034590

Edtadros subscribed.

@Jdlrobson, this needs some test steps so that I don't guess. Or a testable requirement.

Jdlrobson updated the task description. (Show Details)

No QA needed. Thanks Edward. I will also check this in production and add Verified - please feel free to ping me when you are verifying if I haven't done that.