Page MenuHomePhabricator
Create Task
Maniphest T366266

Make captions optional when inputting descriptions
Closed, ResolvedPublic
Actions

Description

Mostly self-explanatory title.

No visual change is expected, we're simply no longer going to prevent submissions with missing captions when descriptions are being provided.

Acceptance criteria

  • When "same as caption" is checked...
    • users can not proceed without entering at least 1 caption
    • captions are stored as usual and visible on the file page's caption section
    • wikitext descriptions are filled with captions' content, visible in the file page's summary section
  • When "same as caption" is unchecked...
    • users can not proceed without entering at least 1 description
    • wikitext descriptions are filled with descriptions' content, visible in the file page's summary section
    • captions are not required; empty captions input means no captions are stored
    • if captions are filled out, they are stored as usual and visible on the file page's caption section

Details

SubjectRepoBranchLines +/-
Make captions optional when adding descriptionsmediawiki/extensions/UploadWizardmaster+97 -49
Customize query in gerrit

Related Objects

Event Timeline

matthiasmullie created this task.Thu, May 30, 11:21 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptThu, May 30, 11:21 AM
matthiasmullie moved this task from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.Thu, May 30, 11:21 AM
gerritbot added a comment.Thu, May 30, 11:21 AM

Change #1037476 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/UploadWizard@master] Make captions optional when adding descriptions

https://gerrit.wikimedia.org/r/1037476

gerritbot added a project: Patch-For-Review.Thu, May 30, 11:21 AM
gerritbot added a comment.Fri, May 31, 12:50 PM

Change #1037476 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Make captions optional when adding descriptions

https://gerrit.wikimedia.org/r/1037476

mfossati moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Fri, May 31, 12:52 PM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.8; 2024-06-04).Fri, May 31, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Fri, May 31, 1:30 PM
Sneha added subscribers: Etonkovidova, Sneha.Fri, May 31, 2:03 PM

Noticed an issue that the error (description is required) appears right away after unchecking "same as caption". And same for error message (caption is required) appears right away after checking "same as caption" box. The error messages are to be triggered only when uploaders try to publish. Before publishing, they may just be trying different options on the page and so showing error message too early can be unexpected and confusing specially to new users.
cc @Etonkovidova

Etonkovidova mentioned this in T365067: UploadWizard - Describe step: message "Caption/Description is required" should appear only upon submitting .Fri, May 31, 7:11 PM
In T366266#9850120, @Sneha wrote:

Noticed an issue that the error (description is required) appears right away after unchecking "same as caption". And same for error message (caption is required) appears right away after checking "same as caption" box. The error messages are to be triggered only when uploaders try to publish. Before publishing, they may just be trying different options on the page and so showing error message too early can be unexpected and confusing specially to new users.
cc @Etonkovidova

@Sneha - I recall that that particular issue was brought up and filed as a separate task: T365067: UploadWizard - Describe step: message "Caption/Description is required" should appear only upon submitting . I added the scenario you described ("Caption is required" after un-checking and re-checking "same as caption" box) to that task.

Etonkovidova added a comment.EditedFri, May 31, 9:08 PM

Checked in commons betalabs - all specs are in place.

Note: it's still non-trivial to realize that captions are optional. If a user uploads a file (and doesn't enters captions or doesn't un-check the "Same as caption" box), clicks "publish files", the message "Caption is required" appears. At this point a user assumes that captions are, indeed, required. And there are also the cases in T365067 as it was mentioned in the comment above.

Etonkovidova updated the task description. (Show Details)Fri, May 31, 9:09 PM
matthiasmullie added a comment.Mon, Jun 3, 2:41 PM

@Etonkovidova Captions remain required if "same as captions" has been unchecked. Only when they uncheck "same as captions" (and fill out a description) do they become optional.

T365067, however, still needs to be dealt with.

Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Mon, Jun 3, 7:06 PM
Etonkovidova closed this task as Resolved.Wed, Jun 5, 7:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL