Page MenuHomePhabricator

Fix heading spacing in Vector
Closed, ResolvedPublic

Description

Background

Followup to https://phabricator.wikimedia.org/T360917 and https://phabricator.wikimedia.org/T362939

In those previous tickets, @JScherer-WMF identified the need to update heading spacings and make them consistent.

User story

  • As a Wikipedia reader, I want consistent spacing and information hierarchy in articles where headers are closer to the text that they are heading and there is enough spacing between paragraphs to differentiate one from another at a glance.

Requirements

Spacing before headings should use a section break, a total of 1.5em
Headers should have 1.5em of space between the top of the header text and the bottom of the element above it.
exception : If a heading is placed directly below another heading, only 1em of space should be between the elements. There's no need for the extra 0.5em of space in this case.
Replace padding with margins

Acceptance criteria

  • Spacing between paragraph and other elements is according to the design

Communication criteria - does this need an announcement or discussion?

  • no

Event Timeline

Jdlrobson subscribed.

Justin needs to talk to DST about this one before it is ready to estimate.

@bwang @Jack_who_built_the_house Is this still an issue? Or did we handle this when we dealt with all the vertical spacing issues as part of the font size deployments earlier this year?

i believe it has been dealt with! i will double check with justin and close if so

Jdlrobson lowered the priority of this task from High to Low.Sep 11 2024, 10:45 PM