Page MenuHomePhabricator

Global Watchlist should be configured to work with the Dark Mode
Open, MediumPublicBUG REPORT

Description

Hi. There is a weird white rectangle in the Vector 2022 Dark Mode.

  • Turn on the "Accessibility for Reading (Vector 2022)" beta feature.
  • Turn on the Dark mode in sidebar / glasses menu.
  • Open the Special:GlobalWatchlist page.
  • Expected: normal appearance.
  • Got: the upper buttons area is white.

It's a minute to fix, just please add

#ext-globalwatchlist-toolbar {
	background: var(--background-color-base)
}

to the style sheet. Thank you.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@IKhitron if adding

#ext-globalwatchlist-toolbar {
	background: var(--background-color-base)
}

is really all that is needed, maybe you want to try sending a patch yourself and I can review it?

@IKhitron if adding

#ext-globalwatchlist-toolbar {
	background: var(--background-color-base)
}

is really all that is needed, maybe you want to try sending a patch yourself and I can review it?

I thought about it. But there are some problems with this, for example:

  • I never sent a wiki patch, so I don't know how to do this.
  • I don't know if the variable exists at all for the users that do not have the beta feature turned on, and if not, the code should include a default value after comma.
  • I can find the default value using color picker in developer tools, but I do not know if it's the only possible, or different users have different default value, depending on there wiki preferences.
  • I do not know if this id has a hardcoded value now, because if it does, the new code should replace the old one, not just be added, and I do not know in how many places the old code exists in different variations.

So it's better somebody that really knows how to do this will use the css code I've provided and will do it the right way.