| DVrandecic | |
| Jun 5 2024, 4:29 PM |
| F57281041: Screenshot from 2024-08-19 11-10-22.png | |
| Aug 19 2024, 9:14 AM |
| F57280945: Screenshot from 2024-08-19 11-02-05.png | |
| Aug 19 2024, 9:14 AM |
| F57280939: Screenshot from 2024-08-19 11-01-26.png | |
| Aug 19 2024, 9:14 AM |
| F54953892: Screenshot 2024-06-05 at 09.28.19.png | |
| Jun 5 2024, 4:30 PM |
Steps to replicate the issue (include links if applicable):
What happens?:
The result, once it appears, is not aligned with the > but seems a bit too low
What should have happened instead?:
It should be aligned
Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
Other information (browser name/version, screenshots, etc.):
The loading part of this ticket (it being slow) is already mentioned and discussed more specifically in https://phabricator.wikimedia.org/T366722
Change #1062372 had a related patch set uploaded (by Daphne Smit; author: Daphne Smit):
[mediawiki/extensions/WikiLambda@master] ZObjectStringRenderer.vue: Rendered result is not aligned with the >
It now looks misaliged with the text slighly pushed up with respect to the arrow:
Before this change:
After this change:
However, overwriting both of them to zero would make it misaligned in cases where there's an error shown below. See the example:
We should make sure that the <p> aligns naturally by having the same height as the button. We can overwrite margin and padding with zero values, but also set line-height to the 32px of the button.
Where did you see the misalignment? I am looking at the ext-wikilambda-app-evaluation-result block. Maybe I am missing a place where it is misaligned
EDIT: Ok I mocked an error and see it now indeed
Change #1062372 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@master] ZObjectStringRenderer.vue: Rendered result is not aligned with the >