📛 [Generalised error] data-policy-violation
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To

Authored By

	Ifrahkhanyaree_WMDE
	Jun 7 2024, 1:19 PM

Description

This is a general error that came out of the discussions surrounding reformatting/rewriting all the collision/conflict errors

Acceptance criteria:

Current errors it will apply to: patch-result-label-description-duplicate, duplicate-label, label-description-duplicate, label-description-same-value, sitelink-conflict
HTTP status code: 422
Error code: data-policy-violation
Error message: Edit violates data policy
Context: { "violation": "{violation}", "violation_context": { "some": "context" } }

Note:

{violation} is one of the existing error codes (see above, minus patch-result- errors)
{violation_context} includes the illegal context, e.g. { "language-code": "foo" }

Task Breakdown

one subtask per:
- duplicate-label
- label-description-duplicate
- label-description-same-value
- sitelink-conflict

Related Objects
Search...

Status	Assigned	Task
Resolved	Ifrahkhanyaree_WMDE	T366908 📛 [Generalised error] data-policy-violation
Resolved	• Muhammad_Yasser_Jazirahly_WMDE	T370794 📛 Replace `duplicate-label` error with `data-policy-violation`
Resolved	• Muhammad_Yasser_Jazirahly_WMDE	T370830 📛 Replace `label-description-duplicate` error with `data-policy-violation`
Resolved	Jakob_WMDE	T370831 📛 Replace `label-description-same-value` error with `data-policy-violation`
Resolved	• Muhammad_Yasser_Jazirahly_WMDE	T370832 📛 Replace `sitelink-conflict` error with `data-policy-violation`

Event Timeline

Ifrahkhanyaree_WMDE created this task.Jun 7 2024, 1:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 7 2024, 1:19 PM

WMDE-leszek updated the task description. (Show Details)Jun 19 2024, 12:18 PM

WMDE-leszek updated the task description. (Show Details)Jun 19 2024, 12:44 PM

WMDE-leszek moved this task from Backlog to Polished on the Wikibase Product Platform Team WPP board.

Ollie.Shotton_WMDE mentioned this in T368398: [MAIN] REST API v1 CHECKLIST.Jun 26 2024, 5:13 PM

Ollie.Shotton_WMDE updated the task description. (Show Details)Jul 4 2024, 1:41 PM

Dev chat notes:

1- Pick option (1):

nested policy context
{
  'violated-policy': 'unique-label-description',
  'violation-context': { 'language-code': 'foo', 'conflicting-item': ...
}

2- Rename violation-policy key to violation inside the error response; violation is easier to communicate rather than inventing the policy name.

3- Reuse old error codes as policy violations.

4- Rename conflicting-item to conflicting-resource.

5- Leave out conflicting-resource in case of self conflicts.

Example:

{
  code: data-policy-violation,
  message: "Edit violates data policy",
  context: {
    'violation': 'label-description-same-value',
    'violation-context': { 'language-code': 'foo' }
  }
}

Ollie.Shotton_WMDE renamed this task from [Generalised error] Data-policy-violation to [Generalised error] data-policy-violation.Jul 10 2024, 10:38 AM

Ollie.Shotton_WMDE updated the task description. (Show Details)

Ifrahkhanyaree_WMDE added a parent task: T368398: [MAIN] REST API v1 CHECKLIST.Jul 17 2024, 9:56 AM

Ifrahkhanyaree_WMDE removed a parent task: T368398: [MAIN] REST API v1 CHECKLIST.Jul 18 2024, 9:53 AM

Ifrahkhanyaree_WMDE set the point value for this task to 5.Jul 22 2024, 10:01 AM

Ifrahkhanyaree_WMDE moved this task from Polished to Ready for planning on the Wikibase Product Platform Team WPP board.

Ifrahkhanyaree_WMDE moved this task from Ready for planning to Sprint 25 on the Wikibase Product Platform Team WPP board.Jul 23 2024, 9:46 AM

Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 25); removed Wikibase Product Platform Team WPP.

Silvan_WMDE updated the task description. (Show Details)Jul 23 2024, 12:55 PM

Dima_Koushha_WMDE renamed this task from [Generalised error] data-policy-violation to 📛 [Generalised error] data-policy-violation.Jul 23 2024, 4:01 PM

Ifrahkhanyaree_WMDE moved this task from Backlog to Happening now on the Wikibase REST API (WPP) board.Jul 26 2024, 2:40 PM

Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 26); removed Wikibase Product Platform Team WPP (Sprint 25).Aug 6 2024, 10:20 AM

Ifrahkhanyaree_WMDE closed subtask T370832: 📛 Replace `sitelink-conflict` error with `data-policy-violation` as Resolved.Aug 6 2024, 10:23 AM

Ifrahkhanyaree_WMDE closed subtask T370830: 📛 Replace `label-description-duplicate` error with `data-policy-violation` as Resolved.

Ifrahkhanyaree_WMDE closed subtask T370794: 📛 Replace `duplicate-label` error with `data-policy-violation` as Resolved.

Jakob_WMDE moved this task from To Do to Product Verification on the Wikibase Product Platform Team WPP (Sprint 26) board.Aug 8 2024, 8:14 AM

Ifrahkhanyaree_WMDE moved this task from Product Verification to Done on the Wikibase Product Platform Team WPP (Sprint 26) board.Aug 9 2024, 11:46 AM

Ifrahkhanyaree_WMDE closed this task as Resolved.Aug 20 2024, 10:01 AM

Ifrahkhanyaree_WMDE claimed this task.

Ifrahkhanyaree_WMDE closed subtask T370831: 📛 Replace `label-description-same-value` error with `data-policy-violation` as Resolved.

Ifrahkhanyaree_WMDE moved this task from Happening now to Done on the Wikibase REST API (WPP) board.Aug 22 2024, 11:59 AM