Upstream issue https://issues.gerritcodereview.com/issues/346174905
Steps to replicate the issue (include links if applicable):
- Use Firefox 126 (stable) or Firefox 128 (nightly)
- Open a Gerrit patch
- Select some text on *file* in a patch
What happens?:
The "press c to comment" button is either at the bottom of the page, or below the viewport, and thus looks like it is not present at all.
Browser console messages (not relevant):
10:40:36.522 Some cookies are misusing the recommended “SameSite“ attribute 5 10:40:37.253 downloadable font: rejected by sanitizer (font-family: "Roboto" style:normal weight:400 stretch:100 src index:0) source: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GlobalBlocking/fonts/roboto/Roboto-Regular.ttf 10:40:37.345 Plugin 'wm-checks-api' was trying to register twice as a Checks UI provider. Ignored. gr-app.js:10963:10943 10:40:37.346 Plugin 'wm-checks-api' was trying to register twice as a Checks UI provider. Ignored. gr-app.js:10963:10943 10:40:37.346 Plugin 'wm-patch-demo' was trying to register twice as a Checks UI provider. Ignored. gr-app.js:10963:10943 10:40:37.353 Plugin 'wm-checks-api' was trying to register twice as a Checks UI provider. Ignored. gr-app.js:10963:10943 10:40:37.353 Plugin 'wm-patch-demo' was trying to register twice as a Checks UI provider. Ignored. gr-app.js:10963:10943 10:40:37.353 Plugin 'wm-pcc' was trying to register twice as a Checks UI provider. Ignored. gr-app.js:10963:10943 10:40:37.362 downloadable font: rejected by sanitizer (font-family: "Roboto" style:normal weight:500 stretch:100 src index:0) source: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GlobalBlocking/fonts/roboto/Roboto-Medium.ttf 10:40:37.934 downloadable font: rejected by sanitizer (font-family: "Roboto Mono" style:normal weight:400 stretch:100 src index:0) source: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GlobalBlocking/fonts/robotomono/RobotoMono-Regular.ttf 10:40:42.267 downloadable font: rejected by sanitizer (font-family: "Roboto Mono" style:normal weight:700 stretch:100 src index:0) source: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GlobalBlocking/fonts/robotomono/RobotoMono-Bold.ttf
What should have happened instead?:
I should see a dialog for adding an inline comment next to the line or region that I've selected.
Other information (browser name/version, screenshots, etc.):
Firefox 126 or Firefox 128 on macOS
Note that commenting on commit messages in a patch works, but the "Add comment" button is placed in an odd location