Page MenuHomePhabricator
Create Task
Maniphest T367248

Tables inside divs should not be wrapped in div.noresize
Open, HighPublic2 Estimated Story PointsBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The table is being wrapped in a noresize class but this shouldn't happen if the table is itself a direct child of a DIV element.

//

screenshot 706.png (906×1 px, 290 KB)

What should have happened instead?:
The table should not be wrapped with div.noresize as div.ts-wikidata-population-table should act as an opt out.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines +/-
Test case: Tables inside divs should not be wrapped in div.noresizemediawiki/skins/Vectormaster+17 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Wed, Jun 12, 12:28 AM
Jdlrobson mentioned this in T366314: Deploy and QA responsive tables change.Wed, Jun 12, 12:49 AM
stjn subscribed.Wed, Jun 12, 12:52 AM

Not ‘breaks on all skins’, breaks in new Vector specifically because of .noresize class. Works fine for me in regular Vector.

Jdlrobson edited projects, added Web-Team-Backlog, Desktop Improvements (Vector 2022); removed Local-Wiki-Template-And-Gadget-Issues.Wed, Jun 12, 1:10 AM

Screenshot 2024-06-11 at 6.09.27 PM.png (1×1 px, 1 MB)

That's how it's supposed to display? Huh. Okay.. I had assumed this shouldn't be floated; the heading shouldn't be overlapping infoboxes; and the [20][21] shouldn't be spilling out in Vector.

But, now I look a bit closer at this, it looks like this is not working to spec. The noresize class shouldn't be kicking in at all as the table has a parent div.ts-wikidata-population-table and we said we wouldn't apply this to tables inside div elements. Retagging.

Jdlrobson renamed this task from [Russian Wikipedia] Template:Wikidata/Population isn't responsive - breaks on all skins to Tables inside divs should not be wrapped in div.noresize.Wed, Jun 12, 1:11 AM
Jdlrobson updated the task description. (Show Details)
stjn added a comment.Wed, Jun 12, 1:19 AM

The caption weirdness on your screenshot seems to be due to trying to fix <caption> issues when a .mw-collapsible table is collapsed (try to remove it: <caption> starts to be displaying one word per line). This should be fixed, yeah. If you know a better way, would be good to fix https://ru.wikipedia.org/wiki/Шаблон:Wikidata/Population/Table/styles.css with it.

There is also some weirdness with how multiple references are displayed, but that I can’t say anything about.

Jdlrobson triaged this task as High priority.Wed, Jun 12, 11:23 PM
gerritbot added a comment.Wed, Jun 12, 11:23 PM

Change #1042415 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Test case: Tables inside divs should not be wrapped in div.noresize

https://gerrit.wikimedia.org/r/1042415

gerritbot added a project: Patch-For-Review.Wed, Jun 12, 11:23 PM
Jdlrobson moved this task from Incoming to FY2023-24 Q4 Sprint 6 on the Web-Team-Backlog board.Wed, Jun 12, 11:23 PM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q4 Sprint 6); removed Web-Team-Backlog.
Jdlrobson moved this task from Needs analysis to Ready for estimation on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.Thu, Jun 13, 5:07 PM
Jdlrobson added a parent task: T361737: [EPIC] With the current layout, some elements extend beyond the content area and overlap sticky page tools.Fri, Jun 14, 5:47 PM
Jdlrobson mentioned this in T367586: [VISUAL CHANGE] [Config] Enable responsive table behaviour on all skins.
Jdlrobson set the point value for this task to 2.Fri, Jun 14, 7:00 PM
ovasileva moved this task from Ready for estimation to Needs analysis on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.Mon, Jun 17, 4:55 PM
ovasileva edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (FY2023-24 Q4 Sprint 6).
Jdlrobson moved this task from Incoming to Groomed on the Web-Team-Backlog board.Tue, Jun 18, 5:53 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL