GrowthExperiments\Tests\Integration\SuggestedEditsSchemaTest::testDefaultTaskTypesDataWithEmptyConfig: Failed asserting that two arrays are equal
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	kostajh
	Jun 19 2024, 9:37 AM

Description

Seen in https://integration.wikimedia.org/ci/job/integration-quibble-fullrun-extensions-phpunit/539/console#console-section-20 and I can reproduce it locally as well.

09:47:11 There was 1 failure:
09:47:11 
09:47:11 1) GrowthExperiments\Tests\Integration\SuggestedEditsSchemaTest::testDefaultTaskTypesDataWithEmptyConfig
09:47:11 Failed asserting that two arrays are equal.
09:47:11 --- Expected
09:47:11 +++ Actual
09:47:11 @@ @@
09:47:11  Array (
09:47:11 -    0 => Array (...)
09:47:11 -    1 => Array (...)
09:47:11 -    2 => Array (...)
09:47:11 -    3 => Array (...)
09:47:11 -    4 => Array (...)
09:47:11 -    5 => Array (...)
09:47:11 -    6 => Array (...)
09:47:11 -    7 => Array (...)
09:47:11  )
09:47:11 
09:47:11 /workspace/src/extensions/GrowthExperiments/tests/phpunit/integration/Config/Schemas/SuggestedEditsSchemaTest.php:188
09:47:11 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106

Details

	Subject	Repo	Branch	Lines +/-
	ci-fullrun-extensions: Load CommunityConfiguration extension	integration/quibble	master	+1 -1
	tests: skip test that depends CommunityConfiguration if it is not loaded	mediawiki/extensions/GrowthExperiments	master	+5 -0

Customize query in gerrit

Related Objects

Mentioned Here: rEGRE8b52aecf022f: tests: assert that tasks can be loaded from empty config

Event Timeline

kostajh created this task.Jun 19 2024, 9:37 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 19 2024, 9:37 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Marking as UBN as it prevents merges to Quibble.

Seems due to rEGRE8b52aecf022f: tests: assert that tasks can be loaded from empty config

Strange. Is CommunityConfiguration not part of quibble? We should change that as it is (going to be) a hard dependency for GrowthExperiments. But first I'll upload a change to unbreak this.

Change #1047466 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] tests: skip test that depends CommunityConfiguration if it is not loaded

https://gerrit.wikimedia.org/r/1047466

gerritbot added a project: Patch-For-Review.Jun 19 2024, 9:49 AM

Change #1047469 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[integration/quibble@master] ci-fullrun-extensions: Load CommunityConfiguration extension

https://gerrit.wikimedia.org/r/1047469

In T367954#9906399, @Michael wrote:

Strange. Is CommunityConfiguration not part of quibble? We should change that as it is (going to be) a hard dependency for GrowthExperiments. But first I'll upload a change two unbreak this.

Thanks @Michael! I made ci-fullrun-extensions: Load CommunityConfiguration extension for that.

kostajh lowered the priority of this task from Unbreak Now! to Needs Triage.Jun 19 2024, 10:15 AM

Change #1047466 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] tests: skip test that depends CommunityConfiguration if it is not loaded

https://gerrit.wikimedia.org/r/1047466

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.11; 2024-06-25).Jun 19 2024, 12:00 PM

Change #1047469 merged by jenkins-bot:

[integration/quibble@master] ci-fullrun-extensions: Load CommunityConfiguration extension

https://gerrit.wikimedia.org/r/1047469

Maintenance_bot removed a project: Patch-For-Review.Jun 19 2024, 7:30 PM

This has been fixed a while ago.

Restricted Application added a project: User-Michael. · View Herald TranscriptJul 2 2024, 3:27 PM

GrowthExperiments\Tests\Integration\SuggestedEditsSchemaTest::testDefaultTaskTypesDataWithEmptyConfig: Failed asserting that two arrays are equalClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

GrowthExperiments\Tests\Integration\SuggestedEditsSchemaTest::testDefaultTaskTypesDataWithEmptyConfig: Failed asserting that two arrays are equal
Closed, ResolvedPublic
Actions