Page MenuHomePhabricator
Create Task
Maniphest T368383

MediaWiki core gate-and-submit test failure: ParserIntegrationTest::testParse with data set "wtEscaping.txt: Links 17. Link trails (T236183)" ('legacy'): Failed asserting that two strings are equal.
Closed, ResolvedPublic
Actions

Description

The following test failed in lots of builds for this unrelated change’s gate-and-submit pipeline:

1) ParserIntegrationTest::testParse with data set "wtEscaping.txt: Links 17. Link trails (T236183)" ('legacy')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<p><a href="/index.php?title=Likalo&amp;action=edit&amp;redlink=1" class="new" title="Likalo (الصفحة غير موجودة)">Likalo</a>&#160;·\n
-<a href="/index.php?title=Pusup%C3%BAsu&amp;action=edit&amp;redlink=1" class="new" title="Pusupúsu (الصفحة غير موجودة)">Pusupúsu</a>&#160;·\n
+'<p><a href="/index.php?title=Likalo&amp;action=edit&amp;redlink=1" class="new" title="Likalo (الصفحه مو موجودة)">Likalo</a>&#160;·\n
+<a href="/index.php?title=Pusup%C3%BAsu&amp;action=edit&amp;redlink=1" class="new" title="Pusupúsu (الصفحه مو موجودة)">Pusupúsu</a>&#160;·\n
 </p>'

The test name points to T236183: Link trail differences between Parsoid/JS & Parsoid/PHP.

Details

SubjectRepoBranchLines +/-
Update expected test output after i18n changemediawiki/coreREL1_39+2 -2
Update expected test output after i18n changemediawiki/coreREL1_42+2 -2
Update expected test output after i18n changemediawiki/coreREL1_41+2 -2
Update expected test output after i18n changemediawiki/coremaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Tue, Jun 25, 10:20 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptTue, Jun 25, 10:20 AM
Lucas_Werkmeister_WMDE added a comment.Tue, Jun 25, 10:20 AM

If I’m not mistaken, the difference is between غير (expected) and مو (actual) in both lines.

Lucas_Werkmeister_WMDE added a comment.Tue, Jun 25, 10:26 AM

I guess the expected output just needs to be updated after red-link-title was changed on TranslateWiki.net? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1049387/1/languages/i18n/ar.json

gerritbot added a comment.Tue, Jun 25, 10:29 AM

Change #1049510 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/core@master] Update expected test output after i18n change

https://gerrit.wikimedia.org/r/1049510

gerritbot added a project: Patch-For-Review.Tue, Jun 25, 10:29 AM
Lucas_Werkmeister_WMDE claimed this task.Tue, Jun 25, 10:29 AM
matmarex subscribed.Tue, Jun 25, 12:47 PM
Lucas_Werkmeister_WMDE added a comment.Tue, Jun 25, 1:19 PM

That’s a huge number of queued changes that are all going to fail, one by one, because the fix needed a second patch set… :blobfoxnotlikethisgoogly:

image.png (1×725 px, 118 KB)

kostajh triaged this task as Unbreak Now! priority.Tue, Jun 25, 3:48 PM
kostajh subscribed.
phuedx subscribed.Tue, Jun 25, 3:52 PM
gerritbot added a comment.Tue, Jun 25, 3:54 PM

Change #1049510 merged by Bartosz Dziewoński:

[mediawiki/core@master] Update expected test output after i18n change

https://gerrit.wikimedia.org/r/1049510

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.12; 2024-07-02).Tue, Jun 25, 4:00 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Tue, Jun 25, 4:00 PM
Lucas_Werkmeister_WMDE lowered the priority of this task from Unbreak Now! to High.
Maintenance_bot removed a project: Patch-For-Review.Tue, Jun 25, 4:30 PM
gerritbot added a comment.Thu, Jun 27, 12:22 PM

Change #1050344 had a related patch set uploaded (by Reedy; author: Lucas Werkmeister (WMDE)):

[mediawiki/core@REL1_42] Update expected test output after i18n change

https://gerrit.wikimedia.org/r/1050344

gerritbot added a project: Patch-For-Review.Thu, Jun 27, 12:22 PM

Change #1050346 had a related patch set uploaded (by Reedy; author: Lucas Werkmeister (WMDE)):

[mediawiki/core@REL1_41] Update expected test output after i18n change

https://gerrit.wikimedia.org/r/1050346

gerritbot added a comment.Thu, Jun 27, 12:23 PM

Change #1050347 had a related patch set uploaded (by Reedy; author: Lucas Werkmeister (WMDE)):

[mediawiki/core@REL1_39] Update expected test output after i18n change

https://gerrit.wikimedia.org/r/1050347

gerritbot added a comment.Thu, Jun 27, 12:23 PM

Change #1050347 abandoned by Reedy:

[mediawiki/core@REL1_39] Update expected test output after i18n change

Reason:

https://gerrit.wikimedia.org/r/1050347

gerritbot added a comment.Thu, Jun 27, 12:44 PM

Change #1050346 merged by jenkins-bot:

[mediawiki/core@REL1_41] Update expected test output after i18n change

https://gerrit.wikimedia.org/r/1050346

ReleaseTaggerBot added a project: MW-1.41-notes.Thu, Jun 27, 1:00 PM
gerritbot added a comment.Thu, Jun 27, 1:46 PM

Change #1050344 merged by jenkins-bot:

[mediawiki/core@REL1_42] Update expected test output after i18n change

https://gerrit.wikimedia.org/r/1050344

ReleaseTaggerBot added a project: MW-1.42-notes.Thu, Jun 27, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Thu, Jun 27, 2:31 PM
gerritbot added a comment.Mon, Jul 1, 3:50 PM

Change #1050347 restored by Bartosz Dziewoński:

[mediawiki/core@REL1_39] Update expected test output after i18n change

https://gerrit.wikimedia.org/r/1050347

gerritbot added a project: Patch-For-Review.Mon, Jul 1, 3:50 PM
gerritbot added a comment.Mon, Jul 1, 5:19 PM

Change #1050347 merged by jenkins-bot:

[mediawiki/core@REL1_39] Update expected test output after i18n change

https://gerrit.wikimedia.org/r/1050347

ReleaseTaggerBot added a project: MW-1.39-notes.Mon, Jul 1, 6:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits