[ 1.43.0-wmf.11 ] TypeError: Cannot convert undefined or null to object in createReferenceWidget
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Jun 27 2024, 11:03 PM

Description

Issue is spiking in 1.43.0-wmf.11 - 5,284 in last 7 days
https://logstash.wikimedia.org/goto/e27766675be2e82d0442c6852e722558

2,272 in last 12 hours - https://logstash.wikimedia.org/goto/85d574e3ddf5dc2174afaebe243d2bd9 so this should block the next train per https://wikitech.wikimedia.org/wiki/Deployments/Holding_the_train#Error-rate_increases_(See_#Logspam)

	at ItemWidget.createReferenceWidget  https://commons.wikimedia.org/w/load.php?lang=en&modules=ext.centralauth.ForeignApi%7Cext.eventLogging%2CwikimediaEvents%7Cext.uls.mediawiki%2Cwebfonts%7Cext.wikimediaEvents.wikibase%7Cjquery%2Coojs-ui-core%7Cjquery.textSelection%2Cui%7Cmediawiki.Uri%2Capi%2Cbase%2Cutil%7Cmediawiki.page.ready%7Cmmv.bootstrap%7Cmw.config.values.wbSiteDetails%7Coojs-ui-core.icons%7Coojs-ui-toolbars.icons%7Coojs-ui-widgets.icons%7Coojs-ui-windows.icons%7Coojs-ui.styles.icons-editing-core%2Cicons-interactions%2Cicons-location%2Cicons-movement%2Cindicators%7Cwikibase.mediainfo.base%2CfilePageDisplay%2Cstatements%2Culs%7Cwikibase.view.ControllerViewFactory&skin=vector&version=i4q5y:1137:131
at ItemWidget.setData  https://commons.wikimedia.org/w/load.php?lang=en&modules=ext.centralauth.ForeignApi%7Cext.eventLogging%2CwikimediaEvents%7Cext.uls.mediawiki%2Cwebfonts%7Cext.wikimediaEvents.wikibase%7Cjquery%2Coojs-ui-core%7Cjquery.textSelection%2Cui%7Cmediawiki.Uri%2Capi%2Cbase%2Cutil%7Cmediawiki.page.ready%7Cmmv.bootstrap%7Cmw.config.values.wbSiteDetails%7Coojs-ui-core.icons%7Coojs-ui-toolbars.icons%7Coojs-ui-widgets.icons%7Coojs-ui-windows.icons%7Coojs-ui.styles.icons-editing-core%2Cicons-interactions%2Cicons-location%2Cicons-movement%2Cindicators%7Cwikibase.mediainfo.base%2CfilePageDisplay%2Cstatements%2Culs%7Cwikibase.view.ControllerViewFactory&skin=vector&version=i4q5y:1138:351
at https://commons.wikimedia.org/w/load.php?lang=en&modules=ext.centralauth.ForeignApi%7Cext.eventLogging%2CwikimediaEvents%7Cext.uls.mediawiki%2Cwebfonts%7Cext.wikimediaEvents.wikibase%7Cjquery%2Coojs-ui-core%7Cjquery.textSelection%2Cui%7Cmediawiki.Uri%2Capi%2Cbase%2Cutil%7Cmediawiki.page.ready%7Cmmv.bootstrap%7Cmw.config.values.wbSiteDetails%7Coojs-ui-core.icons%7Coojs-ui-toolbars.icons%7Coojs-ui-widgets.icons%7Coojs-ui-windows.icons%7Coojs-ui.styles.icons-editing-core%2Cicons-interactions%2Cicons-location%2Cicons-movement%2Cindicators%7Cwikibase.mediainfo.base%2CfilePageDisplay%2Cstatements%2Culs%7Cwikibase.view.ControllerViewFactory&skin=vector&version=i4q5y:1121:699
at StatementWidget.setData  https://commons.wikimedia.org/w/load.php?lang=en&modules=ext.centralauth.ForeignApi%7Cext.eventLogging%2CwikimediaEvents%7Cext.uls.mediawiki%2Cwebfonts%7Cext.wikimediaEvents.wikibase%7Cjquery%2Coojs-ui-core%7Cjquery.textSelection%2Cui%7Cmediawiki.Uri%2Capi%2Cbase%2Cutil%7Cmediawiki.page.ready%7Cmmv.bootstrap%7Cmw.config.values.wbSiteDetails%7Coojs-ui-core.icons%7Coojs-ui-toolbars.icons%7Coojs-ui-widgets.icons%7Coojs-ui-windows.icons%7Coojs-ui.styles.icons-editing-core%2Cicons-interactions%2Cicons-location%2Cicons-movement%2Cindicators%7Cwikibase.mediainfo.base%2CfilePageDisplay%2Cstatements%2Culs%7Cwikibase.view.ControllerViewFactory&skin=vector&version=i4q5y:1121:74
at StatementWidget.resetData  https://commons.wikimedia.org/w/load.php?lang=en&modules=ext.centralauth.ForeignApi%7Cext.eventLogging%2CwikimediaEvents%7Cext.uls.mediawiki%2Cwebfonts%7Cext.wikimediaEvents.wikibase%7Cjquery%2Coojs-ui-core%7Cjquery.textSelection%2Cui%7Cmediawiki.Uri%2Capi%2Cbase%2Cutil%7Cmediawiki.page.ready%7Cmmv.bootstrap%7Cmw.config.values.wbSiteDetails%7Coojs-ui-core.icons%7Coojs-ui-toolbars.icons%7Coojs-ui-widgets.icons%7Coojs-ui-windows.icons%7Coojs-ui.styles.icons-editing-core%2Cicons-interactions%2Cicons-location%2Cicons-movement%2Cindicators%7Cwikibase.mediainfo.base%2CfilePageDisplay%2Cstatements%2Culs%7Cwikibase.view.ControllerViewFactory&skin=vector&version=i4q5y:1123:559
at StatementPanel.setData  https://commons.wikimedia.org/w/load.php?lang=en&modules=ext.centralauth.ForeignApi%7Cext.eventLogging%2CwikimediaEvents%7Cext.uls.mediawiki%2Cwebfonts%7Cext.wikimediaEvents.wikibase%7Cjquery%2Coojs-ui-core%7Cjquery.textSelection%2Cui%7Cmediawiki.Uri%2Capi%2Cbase%2Cutil%7Cmediawiki.page.ready%7Cmmv.bootstrap%7Cmw.config.values.wbSiteDetails%7Coojs-ui-core.icons%7Coojs-ui-toolbars.icons%7Coojs-ui-widgets.icons%7Coojs-ui-windows.icons%7Coojs-ui.styles.icons-editing-core%2Cicons-interactions%2Cicons-location%2Cicons-movement%2Cindicators%7Cwikibase.mediainfo.base%2CfilePageDisplay%2Cstatements%2Culs%7Cwikibase.view.ControllerViewFactory&skin=vector&version=i4q5y:1107:782
at https://commons.wikimedia.org/w/load.php?lang=en&modules=ext.centralauth.ForeignApi%7Cext.eventLogging%2CwikimediaEvents%7Cext.uls.mediawiki%2Cwebfonts%7Cext.wikimediaEvents.wikibase%7Cjquery%2Coojs-ui-core%7Cjquery.textSelection%2Cui%7Cmediawiki.Uri%2Capi%2Cbase%2Cutil%7Cmediawiki.page.ready%7Cmmv.bootstrap%7Cmw.config.values.wbSiteDetails%7Coojs-ui-core.icons%7Coojs-ui-toolbars.icons%7Coojs-ui-widgets.icons%7Coojs-ui-windows.icons%7Coojs-ui.styles.icons-editing-core%2Cicons-interactions%2Cicons-location%2Cicons-movement%2Cindicators%7Cwikibase.mediainfo.base%2CfilePageDisplay%2Cstatements%2Culs%7Cwikibase.view.ControllerViewFactory&skin=vector&version=i4q5y:1077:334

Steps to replicate the issue (include links if applicable):

What happens?:

What should have happened instead?:

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Related Objects

Mentioned In: T366957: 1.43.0-wmf.12 deployment blockers
Mentioned Here: T368736: Structured Data add reference not working

Event Timeline

Jdlrobson created this task.Jun 27 2024, 11:03 PM

Restricted Application added a project: Structured-Data-Backlog. · View Herald TranscriptJun 27 2024, 11:03 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Jdlrobson mentioned this in T366957: 1.43.0-wmf.12 deployment blockers.Jun 27 2024, 11:07 PM

Jdlrobson added a parent task: T366957: 1.43.0-wmf.12 deployment blockers.

Jdlrobson renamed this task from TypeError: Cannot convert undefined or null to object to [ 1.43.0-wmf.11 ] TypeError: Cannot convert undefined or null to object in createReferenceWidget.Jun 27 2024, 11:11 PM

Jdlrobson updated the task description. (Show Details)

Train blockers are unbreak now priority.

Possibly related to T368736

It looks like ddebcc1a9637dfb7fa1318924d8201b51aff88a9 is the problem - in particular the replacement of $.extend() with Object.assign(). @Jdlrobson any thoughts?

I left an explanation here: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/1047242

Just +2ed this https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/1051166 - we think it should fix the problem

@Jdlrobson is there anything else we need to do?

Ideally this would be backported to wmf.11, to verify the fix and give us more confidence in the next train that the issue has been handled (eg. hasn't caused another error). I think we can remove it as a deploy blocker though.

Jdlrobson removed a parent task: T366957: 1.43.0-wmf.12 deployment blockers.Jul 1 2024, 6:56 PM

Jdforrester-WMF merged a task: T368736: Structured Data add reference not working.Jul 2 2024, 10:44 AM

Jdforrester-WMF added subscribers: diegodlh, mfossati.

Landed in wmf.12, backported to wmf.11, and appears fixed.

mfossati awarded a token.Jul 3 2024, 8:17 AM

[ 1.43.0-wmf.11 ] TypeError: Cannot convert undefined or null to object in createReferenceWidgetClosed, ResolvedPublicBUG REPORTActions

Description

Related Objects

Event Timeline

[ 1.43.0-wmf.11 ] TypeError: Cannot convert undefined or null to object in createReferenceWidget
Closed, ResolvedPublicBUG REPORT
Actions