Page MenuHomePhabricator

[ 1.43.0-wmf.11 ] TypeError: Cannot convert undefined or null to object in createReferenceWidget
Closed, ResolvedPublicBUG REPORT


Issue is spiking in 1.43.0-wmf.11 - 5,284 in last 7 days

2,272 in last 12 hours - so this should block the next train per

	at ItemWidget.createReferenceWidget
at ItemWidget.setData
at StatementWidget.setData
at StatementWidget.resetData
at StatementPanel.setData

Steps to replicate the issue (include links if applicable):

What happens?:

What should have happened instead?:

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdlrobson renamed this task from TypeError: Cannot convert undefined or null to object to [ 1.43.0-wmf.11 ] TypeError: Cannot convert undefined or null to object in createReferenceWidget.Thu, Jun 27, 11:11 PM
Jdlrobson updated the task description. (Show Details)
hashar triaged this task as Unbreak Now! priority.Mon, Jul 1, 3:45 PM
hashar subscribed.

Train blockers are unbreak now priority.

It looks like ddebcc1a9637dfb7fa1318924d8201b51aff88a9 is the problem - in particular the replacement of $.extend() with Object.assign(). @Jdlrobson any thoughts?

@Jdlrobson is there anything else we need to do?

Ideally this would be backported to wmf.11, to verify the fix and give us more confidence in the next train that the issue has been handled (eg. hasn't caused another error). I think we can remove it as a deploy blocker though.

Jdforrester-WMF assigned this task to mfossati.
Jdforrester-WMF subscribed.

Landed in wmf.12, backported to wmf.11, and appears fixed.