Page MenuHomePhabricator

Logging epic nice-to-have: Adding stack trace for every log output
Closed, ResolvedPublic

Description

What/Why:
From investigating our logger so far, it seems our 'trace' log level doesn't do anything a trace level would normally have, a stack trace; in fact, none of the logging levels do anything unique other than their difference in log level (currently emitting numeric values and not label). It would be very helpful to see the stack trace or at least which file and line the log came from.

How: We can raise a bunyan error for any log which I think should emit a stack trace. I haven't tested this out yet but I believe this would be a way to do this. Any other ideas welcome.

Event Timeline

ecarg renamed this task from Logging epic subtask nice-to-have/stretch goal: Adding stack trace for every log output to Logging epic nice-to-have: Adding stack trace for every log output.Jul 3 2024, 7:13 PM
ecarg claimed this task.

does this need subtasks for orch and eval?

ecarg changed the task status from Open to In Progress.Jul 3 2024, 7:14 PM

Change #1053622 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (eb689ce)

https://gerrit.wikimedia.org/r/1053622

Change #1054886 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-07-09-155027 to 2024-07-17-140123

https://gerrit.wikimedia.org/r/1054886

Change #1054886 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-07-09-155027 to 2024-07-17-140123

https://gerrit.wikimedia.org/r/1054886

Change #1054909 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-07-09-154549 to 2024-07-17-145805

https://gerrit.wikimedia.org/r/1054909

Change #1053622 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (a0fd03c)

https://gerrit.wikimedia.org/r/1053622

Change #1054909 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-07-09-154549 to 2024-07-17-145805

https://gerrit.wikimedia.org/r/1054909

We have a stack trace for every log output now, this has been resolved.