Page MenuHomePhabricator

[Refactor] Extract edit panel from VE Cite code
Closed, ResolvedPublic

Description

The MWReferenceDialog from the Cite codebase is responsible for all things related to adding, editing and re-using references and includes a lot of code to build the UI for all three use cases. Extracting some of the logic to separate widgets would help in general there. - But furthermore Cite-Extends also needs a dialog so that users can set the additional content and would profit a lot from a re-usable widget that encapsulates everything that's relevant to set and manipulate a reference's content.

Implementation ideas:
Extract a widget ( probably as TabPanelLayout ) that

  • builds the editor interface
  • can be used for creating, editing and extending references
  • is responsible for the re-use and extends warnings on editing

Event Timeline

Change #1055083 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Citoid@master] Fix close button disappearing on the "extends" tab

https://gerrit.wikimedia.org/r/1055083

Change #1055084 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Disallow recursively extending already extended references

https://gerrit.wikimedia.org/r/1055084

Change #1055083 merged by jenkins-bot:

[mediawiki/extensions/Citoid@master] Fix close button disappearing on the "extends" tab

https://gerrit.wikimedia.org/r/1055083

Change #1055084 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Disallow recursively extending already extended references

https://gerrit.wikimedia.org/r/1055084

Change #1055180 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] Introduce MWReferenceEditPanel to extract editing UI

https://gerrit.wikimedia.org/r/1055180

Change #1055265 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Citoid@master] Use ExcludeCommands and ImportRules from new MWReferenceEditPanel

https://gerrit.wikimedia.org/r/1055265

Change #1055273 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] Remove static leftovers that moved to MWReferenceEditPanel

https://gerrit.wikimedia.org/r/1055273

Change #1055180 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Introduce MWReferenceEditPanel to extract editing UI

https://gerrit.wikimedia.org/r/1055180

Change #1055897 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] Fix broken reference to the new EditPanel class

https://gerrit.wikimedia.org/r/1055897

Change #1055265 merged by jenkins-bot:

[mediawiki/extensions/Citoid@master] Use ExcludeCommands and ImportRules from new MWReferenceEditPanel

https://gerrit.wikimedia.org/r/1055265

Change #1055273 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Remove static leftovers that moved to MWReferenceEditPanel

https://gerrit.wikimedia.org/r/1055273

Change #1055897 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Fix broken reference to the new EditPanel class

https://gerrit.wikimedia.org/r/1055897

Change #1056548 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] Move more editing methods to the EditPanel

https://gerrit.wikimedia.org/r/1056548

Change #1057357 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] Move event handler to the EditPanel class

https://gerrit.wikimedia.org/r/1057357

Change #1056548 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Move more editing methods to the EditPanel

https://gerrit.wikimedia.org/r/1056548

Change #1059100 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] Add method to get the updated ref from the edit panel

https://gerrit.wikimedia.org/r/1059100

Change #1059263 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] Remove obsolete disconnect()

https://gerrit.wikimedia.org/r/1059263

WMDE-Fisch updated the task description. (Show Details)

Change #1059365 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] Hide main ref warning on orphan refs

https://gerrit.wikimedia.org/r/1059365

Change #1059263 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Remove obsolete disconnect()

https://gerrit.wikimedia.org/r/1059263

Change #1061971 had a related patch set uploaded (by Mareike Heuer; author: Mareike Heuer):

[mediawiki/extensions/Cite@master] DNM patch

https://gerrit.wikimedia.org/r/1061971

Change #1059365 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Hide main ref warning on orphan refs

https://gerrit.wikimedia.org/r/1059365

Change #1059100 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Add method to get the updated ref from the edit panel

https://gerrit.wikimedia.org/r/1059100

Change #1061971 abandoned by Mareike Heuer:

[mediawiki/extensions/Cite@master] DNM patch

https://gerrit.wikimedia.org/r/1061971

Change #1057357 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Move event handler to the EditPanel class

https://gerrit.wikimedia.org/r/1057357

Change #1062447 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] Git rid of the referenceModel in the dialog class

https://gerrit.wikimedia.org/r/1062447

Change #1062454 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] Set more methods private in EditPanel class

https://gerrit.wikimedia.org/r/1062454

Change #1062454 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Set more methods private in EditPanel class

https://gerrit.wikimedia.org/r/1062454

Change #1062447 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Git rid of the ref class property in the dialog class

https://gerrit.wikimedia.org/r/1062447