Page MenuHomePhabricator

Figure out how to handle "remember me" flag in SUL3 login flow
Closed, ResolvedPublic

Description

If the user checks the "keep me logged in" checkbox on the central wiki when using the SUL3 (T348388: SUL3: Use a dedicated domain for login and account creation) login flow, we want the local session to also use that flag. But the in the local AuthManager workflow, RememberMeAuthenticationRequest gets processed before the redirect so not clear how we can do that.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1056590 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] auth: Allow a primary authentication to inject RememberMe request

https://gerrit.wikimedia.org/r/1056590

Change #1056592 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/CentralAuth@master] Allow using "remember me" set in the central SSO wiki

https://gerrit.wikimedia.org/r/1056592

DAlangi_WMF changed the task status from Open to In Progress.Jul 24 2024, 7:51 PM
DAlangi_WMF claimed this task.

Change #1056590 merged by jenkins-bot:

[mediawiki/core@master] SUL3: Enable multiple auth providers to refresh "remember me" status

https://gerrit.wikimedia.org/r/1056590

Change #1056592 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] SUL3: Allow using "remember me" set on the shared domain

https://gerrit.wikimedia.org/r/1056592

matmarex removed a project: Patch-For-Review.
matmarex subscribed.

Change #1081978 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/CentralAuth@master] SUL3: Fix remember flag handling

https://gerrit.wikimedia.org/r/1081978

Change #1081978 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] SUL3: Fix remember flag handling

https://gerrit.wikimedia.org/r/1081978