Page MenuHomePhabricator
Create Task
Maniphest T370161

"Call to a member function equals() on null" when rolling back a change with a suppressed username
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Seen by @Dogu when trying to do a rollback on `https://tr.wikipedia.org/wiki/1,1,1-Trikloroetan after an edit with a suppressed username.

Error
normalized_message
[{reqId}] {exception_url}   Error: Call to a member function equals() on null
exception.trace
from /srv/mediawiki/php-1.43.0-wmf.13/extensions/AutoModerator/src/RevisionCheck.php(270)
#0 /srv/mediawiki/php-1.43.0-wmf.13/extensions/AutoModerator/src/Hooks/RevisionFromEditCompleteHookHandler.php(121): AutoModerator\RevisionCheck::revertPreCheck(MediaWiki\User\User, MediaWiki\User\User, Monolog\Logger, MediaWiki\Revision\RevisionStore, array, MediaWiki\Permissions\RestrictionStore, MediaWiki\Page\WikiPageFactory, MediaWiki\User\UserGroupManager, AutoModerator\Config\AutoModeratorWikiConfigLoader, integer, integer)
#1 /srv/mediawiki/php-1.43.0-wmf.13/extensions/AutoModerator/src/Hooks.php(89): AutoModerator\Hooks\RevisionFromEditCompleteHookHandler->handle(WikiPage, MediaWiki\Revision\RevisionStoreRecord, integer, MediaWiki\User\User, array)
#2 /srv/mediawiki/php-1.43.0-wmf.13/includes/HookContainer/HookContainer.php(159): AutoModerator\Hooks->onRevisionFromEditComplete(WikiPage, MediaWiki\Revision\RevisionStoreRecord, integer, MediaWiki\User\User, array)
#3 /srv/mediawiki/php-1.43.0-wmf.13/includes/HookContainer/HookRunner.php(3290): MediaWiki\HookContainer\HookContainer->run(string, array)
#4 /srv/mediawiki/php-1.43.0-wmf.13/includes/Storage/PageUpdater.php(1387): MediaWiki\HookContainer\HookRunner->onRevisionFromEditComplete(WikiPage, MediaWiki\Revision\RevisionStoreRecord, integer, MediaWiki\User\User, array)
#5 /srv/mediawiki/php-1.43.0-wmf.13/includes/Storage/PageUpdater.php(923): MediaWiki\Storage\PageUpdater->doModify(MediaWiki\CommentStore\CommentStoreComment)
#6 /srv/mediawiki/php-1.43.0-wmf.13/includes/page/RollbackPage.php(319): MediaWiki\Storage\PageUpdater->saveRevision(MediaWiki\CommentStore\CommentStoreComment, integer)
#7 /srv/mediawiki/php-1.43.0-wmf.13/includes/page/RollbackPage.php(198): MediaWiki\Page\RollbackPage->rollback()
#8 /srv/mediawiki/php-1.43.0-wmf.13/includes/actions/RollbackAction.php(188): MediaWiki\Page\RollbackPage->rollbackIfAllowed()
#9 /srv/mediawiki/php-1.43.0-wmf.13/includes/actions/RollbackAction.php(136): RollbackAction->handleRollbackRequest()
#10 /srv/mediawiki/php-1.43.0-wmf.13/includes/actions/ActionEntryPoint.php(731): RollbackAction->show()
#11 /srv/mediawiki/php-1.43.0-wmf.13/includes/actions/ActionEntryPoint.php(508): MediaWiki\Actions\ActionEntryPoint->performAction(Article, MediaWiki\Title\Title)
#12 /srv/mediawiki/php-1.43.0-wmf.13/includes/actions/ActionEntryPoint.php(145): MediaWiki\Actions\ActionEntryPoint->performRequest()
#13 /srv/mediawiki/php-1.43.0-wmf.13/includes/MediaWikiEntryPoint.php(200): MediaWiki\Actions\ActionEntryPoint->execute()
#14 /srv/mediawiki/php-1.43.0-wmf.13/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#15 /srv/mediawiki/w/index.php(3): require(string)
#16 {main}

Impact

Prevents reverts of bad edits, both rollback and manual.

Details

Request URL
https://tr.wikipedia.org/w/index.php?action=rollback&from=*&title=*&token=*
SubjectRepoBranchLines +/-
Fix guard clause in Revision Hook Handler and Precheckmediawiki/extensions/AutoModeratorwmf/1.43.0-wmf.14+16 -5
Fix guard clause in Revision Hook Handler and Precheckmediawiki/extensions/AutoModeratormaster+16 -5
Customize query in gerrit

Related Objects

Event Timeline

Tgr created this task.Jul 16 2024, 2:03 PM
Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptJul 16 2024, 2:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Scardenasmolinar changed the task status from Open to In Progress.Jul 16 2024, 7:09 PM
Scardenasmolinar claimed this task.
Scardenasmolinar triaged this task as High priority.
Scardenasmolinar edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.
Scardenasmolinar moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
jsn.sherman subscribed.Jul 16 2024, 8:11 PM

Since this is happening in the revision precheck, it, we should be able to stop the error immediately by disabling automoderator here:
https://tr.wikipedia.org/wiki/MediaWiki:AutoModeratorConfig.json
that would be something that @Dogu or another interface admin could do while we get a patch out

Dogu added a comment.Jul 16 2024, 8:12 PM

Done! @jsn.sherman

jsn.sherman added a comment.Jul 16 2024, 8:15 PM
In T370161#9987811, @Dogu wrote:

Done! @jsn.sherman

Awesome; can somebody try redoing an impacted revert to verify that things are mitigated?

jsn.sherman added a comment.Jul 16 2024, 8:17 PM

@Scardenasmolinar
it looks like we're calling equals() on the return value of getUser() without checking to see if it actually returned a user. That seems like the most likely cuplrit:
https://codesearch.wmcloud.org/things/?q=equals&files=%5Esrc%5C%2F.%2B%5C.php%24&excludeFiles=&repos=Extension%3AAutoModerator

Scardenasmolinar added a comment.Jul 16 2024, 11:05 PM
In T370161#9987822, @jsn.sherman wrote:

@Scardenasmolinar
it looks like we're calling equals() on the return value of getUser() without checking to see if it actually returned a user. That seems like the most likely cuplrit:
https://codesearch.wmcloud.org/things/?q=equals&files=%5Esrc%5C%2F.%2B%5C.php%24&excludeFiles=&repos=Extension%3AAutoModerator

Yes, I also reached the same conclusion. Our guard clause that checks for null users and revisions is not catching this. I have a fix incoming.

gerritbot added a comment.Jul 16 2024, 11:12 PM

Change #1054675 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/AutoModerator@master] Fix guard clause in Revision Hook Handler

https://gerrit.wikimedia.org/r/1054675

gerritbot added a project: Patch-For-Review.Jul 16 2024, 11:12 PM
Scardenasmolinar moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Jul 16 2024, 11:46 PM
jsn.sherman moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Jul 17 2024, 2:01 PM
Scardenasmolinar moved this task from Reviewed (waiting for changes) to Eng review on the Moderator-Tools-Team (Kanban) board.Jul 17 2024, 7:03 PM
Kgraessle moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Jul 18 2024, 1:43 PM
Kgraessle moved this task from Reviewed (waiting for changes) to Eng review on the Moderator-Tools-Team (Kanban) board.Jul 18 2024, 3:59 PM
gerritbot added a comment.Jul 18 2024, 6:37 PM

Change #1054675 merged by jenkins-bot:

[mediawiki/extensions/AutoModerator@master] Fix guard clause in Revision Hook Handler and Precheck

https://gerrit.wikimedia.org/r/1054675

Scardenasmolinar mentioned this in rEAMO599b8c4829ae: Fix guard clause in Revision Hook Handler and Precheck.Jul 18 2024, 6:37 PM
gerritbot added a comment.Jul 18 2024, 6:41 PM

Change #1055274 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/AutoModerator@wmf/1.43.0-wmf.14] Fix guard clause in Revision Hook Handler and Precheck

https://gerrit.wikimedia.org/r/1055274

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.15; 2024-07-23).Jul 18 2024, 7:00 PM
gerritbot added a comment.Jul 18 2024, 9:01 PM

Change #1055274 merged by jenkins-bot:

[mediawiki/extensions/AutoModerator@wmf/1.43.0-wmf.14] Fix guard clause in Revision Hook Handler and Precheck

https://gerrit.wikimedia.org/r/1055274

Scardenasmolinar mentioned this in rEAMO507d96afd901: Fix guard clause in Revision Hook Handler and Precheck.Jul 18 2024, 9:01 PM
Stashbot added a comment.Jul 18 2024, 9:02 PM

Mentioned in SAL (#wikimedia-operations) [2024-07-18T21:02:18Z] <dancy@deploy1002> Started scap sync-world: Backport for [[gerrit:1055274|Fix guard clause in Revision Hook Handler and Precheck (T370161)]]

Stashbot added a comment.Jul 18 2024, 9:04 PM

Mentioned in SAL (#wikimedia-operations) [2024-07-18T21:04:37Z] <dancy@deploy1002> suecarmol, dancy: Backport for [[gerrit:1055274|Fix guard clause in Revision Hook Handler and Precheck (T370161)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Jul 18 2024, 9:14 PM

Mentioned in SAL (#wikimedia-operations) [2024-07-18T21:14:21Z] <dancy@deploy1002> Finished scap: Backport for [[gerrit:1055274|Fix guard clause in Revision Hook Handler and Precheck (T370161)]] (duration: 12m 02s)

Kgraessle moved this task from Eng review to QA on the Moderator-Tools-Team (Kanban) board.Jul 18 2024, 9:19 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 18 2024, 9:30 PM
ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.14; 2024-07-16); removed MW-1.43-notes (1.43.0-wmf.15; 2024-07-23).Jul 18 2024, 10:00 PM
Scardenasmolinar added a comment.Jul 19 2024, 3:51 PM

@Dogu, we have made a backport to fix the error. You can now re-enable AutoModerator. If you see any new errors (or the same one) pop-up, let us know in this ticket.

Dogu added a comment.Jul 19 2024, 6:20 PM

@Scardenasmolinar Done!

jsn.sherman mentioned this in T370515: Analyse the reverts on trwiki that were not reverted by Automoderator.Jul 22 2024, 1:55 PM
DMburugu moved this task from QA to Done on the Moderator-Tools-Team (Kanban) board.Jul 22 2024, 3:07 PM
Scardenasmolinar closed this task as Resolved.Jul 22 2024, 3:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits