Page MenuHomePhabricator

Table: fix sort icon size
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

The sort icons are tiny:

image.png (546×1 px, 80 KB)

What should have happened instead?:

They should be 16px square (icon size small):

image.png (540×1 px, 75 KB)

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia): Codex 1.8.0


This is happening on MPIC because there's a box-sizing: border-box style applied to everything via the wildcard selector, which means the icon's padding-left is included in its total size. We could change the padding to a margin to avoid this issue, and because it's more semantically correct (the space is meant to separate the icon from the label it's next to).

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
CCiufo-WMF triaged this task as Medium priority.Jul 26 2024, 7:54 PM
CCiufo-WMF moved this task from Inbox to Up Next on the Design-System-Team board.
AnneT changed the task status from Open to In Progress.Aug 5 2024, 6:42 PM
AnneT claimed this task.

Change #1059934 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[design/codex@main] Table: Fix sort icon spacing

https://gerrit.wikimedia.org/r/1059934

Change #1059934 merged by jenkins-bot:

[design/codex@main] Table: Fix sort icon spacing

https://gerrit.wikimedia.org/r/1059934

Change #1060504 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/core@master] Update Codex from v1.10.0 to v1.11.0

https://gerrit.wikimedia.org/r/1060504

Test wiki created on Patch demo by EGardner (WMF) using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/e5da39d6d5/w

Change #1060504 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.10.0 to v1.11.0

https://gerrit.wikimedia.org/r/1060504