Page MenuHomePhabricator

Electron/Collection/Proton cleanup
Open, Needs TriagePublic

Description

These extensions are not well maintained and a bunch of cruft has piled up by the multiple switches of technology over the years. This is a list of some things we should probably clean up a bit ?

  • Make ElectronPdfService not rely on Collection to add the Print/Export menu T256071
    • Should add its own "download as PDF" item
    • Should remove the "download as PDF" items from Collection when present
    • Both sections should use the same id
    • Review if the correct hooks are still used to modify the sidebar
  • Set wgCollectionPortletFormats and wgCollectionFormats to empty array for WMF. This disables the download as PDF link from being added. T370740
  • Remove electron service stuff for what is now handled by Proton
  • Rework electron extension into a print/export sidebar extension ? or should the print/export section become part of core ?
  • Remove any broken export logic from the Collection extension

Event Timeline

Change #1057277 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/ElectronPdfService@master] Remove styling logic for the old Electron service

https://gerrit.wikimedia.org/r/1057277

Change #1057277 merged by jenkins-bot:

[mediawiki/extensions/ElectronPdfService@master] Remove styling logic for the old Electron service

https://gerrit.wikimedia.org/r/1057277

Change #1058251 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/ElectronPdfService@master] Use ExtensionRegistry instead of relying on loaded config

https://gerrit.wikimedia.org/r/1058251

Change #1058251 merged by jenkins-bot:

[mediawiki/extensions/ElectronPdfService@master] Use ExtensionRegistry instead of relying on loaded config

https://gerrit.wikimedia.org/r/1058251