Page MenuHomePhabricator
Create Task
Maniphest T372722

Prompt user to log in to access Special:My* pages
Closed, ResolvedPublic
Actions

Description

Currently, when not logged-in, if you visit any of the Special:My* pages ( 'Mycontributions', 'MyLanguage', 'Mylog', 'Mypage', 'Mytalk', 'Myuploads') you will see contributions for your IP address.

For wikis with temporary accounts, showing the contributions for an IP address doesn't make sense anymore.

Proposed change: when temporary accounts are enabled, if the user is logged-out, we should require the user to login to access these pages.

Note that If the user is already logged-in with a temporary account, then the Special:My* pages will work just fine as is, without any changes needed.

Details

SubjectRepoBranchLines +/-
Hide user links for anon users when temp accounts are enabledmediawiki/coremaster+8 -2
Hide user links for anon users when temp accounts are enabledmediawiki/skins/Vectormaster+17 -1
Prompt user to log in to access Special:My* pagesmediawiki/coremaster+101 -6
Customize query in gerrit

Related Objects

Event Timeline

kostajh created this task.Aug 19 2024, 4:55 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 19 2024, 4:55 AM
Bugreporter subscribed.Aug 19 2024, 7:39 AM

In addition we should also hide links to Special:MyContributions and Special:MyTalk in personal tools at the top of the page.

kostajh added a comment.Aug 19 2024, 1:03 PM
In T372722#10072057, @Bugreporter wrote:

In addition we should also hide links to Special:MyContributions and Special:MyTalk in personal tools at the top of the page.

Good catch, thanks. If we remove those links, should add anything else in their place? cc @Niharika

image.png (362×594 px, 31 KB)

Niharika added a comment.Aug 20 2024, 3:53 AM
In T372722#10073089, @kostajh wrote:
In T372722#10072057, @Bugreporter wrote:

In addition we should also hide links to Special:MyContributions and Special:MyTalk in personal tools at the top of the page.

Good catch, thanks. If we remove those links, should add anything else in their place? cc @Niharika

image.png (362×594 px, 31 KB)

Let's skip adding there for now. I cannot think of anything that would be useful for temp accounts to have. They are getting access to notifications anyway which should point them to relevant places.

kostajh edited projects, added Temporary accounts (Blockers to minor pilot wiki deployment), Trust and Safety Product Sprint; removed Temporary accounts.Aug 20 2024, 6:15 AM
Amdrel claimed this task.Sep 10 2024, 11:54 PM
Amdrel changed the task status from Open to In Progress.Sep 13 2024, 4:44 PM
kostajh moved this task from Backlog to In progress on the Temporary accounts (Blockers to minor pilot wiki deployment) board.Sep 16 2024, 8:42 AM
kostajh edited projects, added Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)); removed Trust and Safety Product Sprint.Sep 16 2024, 10:51 AM
gerritbot added a comment.Sep 16 2024, 10:15 PM

Change #1073294 had a related patch set uploaded (by Amdrel; author: Amdrel):

[mediawiki/core@master] Prompt user to log in to access Special:My* pages

https://gerrit.wikimedia.org/r/1073294

gerritbot added a project: Patch-For-Review.Sep 16 2024, 10:15 PM
Amdrel added a comment.Sep 16 2024, 10:41 PM

I added a patch that adds redirects to all the listed pages except for 'Special:MyLanguage'. I don't think we should require a login for that special page redirect since my understanding is that it is used for links to translated pages to ensure that users get localized results for wikis that support that. I believe it defaults to the default wiki language for anonymous users. Let me know your thoughts.

gerritbot added a comment.Sep 16 2024, 10:45 PM

Change #1073295 had a related patch set uploaded (by Amdrel; author: Amdrel):

[mediawiki/skins/Vector@master] Hide user links for anon users when temp accounts are enabled

https://gerrit.wikimedia.org/r/1073295

Niharika added a comment.Sep 18 2024, 11:33 AM
In T372722#10151085, @Amdrel wrote:

I added a patch that adds redirects to all the listed pages except for 'Special:MyLanguage'. I don't think we should require a login for that special page redirect since my understanding is that it is used for links to translated pages to ensure that users get localized results for wikis that support that. I believe it defaults to the default wiki language for anonymous users. Let me know your thoughts.

That makes sense. Thanks for thinking this through.

kostajh moved this task from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)) board.Sep 19 2024, 7:43 PM
gerritbot added a comment.Sep 19 2024, 8:14 PM

Change #1073294 merged by jenkins-bot:

[mediawiki/core@master] Prompt user to log in to access Special:My* pages

https://gerrit.wikimedia.org/r/1073294

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.24; 2024-09-24).Sep 19 2024, 9:00 PM
gerritbot added a comment.Sep 20 2024, 6:49 PM

Change #1074503 had a related patch set uploaded (by Amdrel; author: Amdrel):

[mediawiki/core@master] Hide user links for anon users when temp accounts are enabled

https://gerrit.wikimedia.org/r/1074503

gerritbot added a comment.Sep 20 2024, 6:50 PM

Change #1073295 abandoned by Amdrel:

[mediawiki/skins/Vector@master] Hide user links for anon users when temp accounts are enabled

Reason:

Supplanted by I4d883aea869c742b32bbbba46009ded9dddd0835

https://gerrit.wikimedia.org/r/1073295

Krinkle mentioned this in T375315: Information button for tempuser after first edit creates unreadable modal.Sep 21 2024, 12:46 AM
gerritbot added a comment.Sep 23 2024, 9:20 AM

Change #1074503 merged by jenkins-bot:

[mediawiki/core@master] Hide user links for anon users when temp accounts are enabled

https://gerrit.wikimedia.org/r/1074503

Maintenance_bot removed a project: Patch-For-Review.Sep 23 2024, 9:30 AM
Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)) board.Sep 25 2024, 4:51 AM
Djackson-ctr subscribed.

QA has been completed, and the new code change(s) are functioning as expected (when temporary accounts are enabled, if the user is logged-out and tries to access Special:My*pages, the user will be redirected to the login page, also user links will be hidden for anon users when temp accounts are enabled).

kostajh closed this task as Resolved.Sep 25 2024, 6:01 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits