Page MenuHomePhabricator
Create Task
Maniphest T372904

Use page_weighted_tags_changed stream
Open, In Progress, Needs TriagePublic
Actions

Description

Make sure, growth maintenance scripts use page_weighted_tags_changed (since T366253) for adding/clearing weighted tags.

AC:

  • replace per-use-case streams with page_weighted_tags_changed
  • adapt SearchIndexUpdater / EventGateSearchIndexUpdater so it can clear tags

Details

SubjectRepoBranchLines +/-
Use WeightedTagsUpdatermediawiki/extensions/GrowthExperimentsmaster+67 -182
WeightedTagsUpdater: add support for trigger hint (rev_based flag)mediawiki/extensions/CirrusSearchmaster+161 -38
Extract MultiListBuilder.phpmediawiki/extensions/CirrusSearchmaster+332 -50
Extract WeightedTagsUpdater and add EventBusWeightedTagsUpdater implementationmediawiki/extensions/CirrusSearchmaster+679 -186
Let PageEntitySerializer.canonicalPageURL accept PageReferencemediawiki/extensions/EventBuswmf/1.43.0-wmf.21+13 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

pfischer created this task.Aug 20 2024, 2:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 20 2024, 2:53 PM
pfischer added a parent task: T366253: Create a generic stream to populate CirrusSearch weighted_tags.Aug 20 2024, 2:53 PM
pfischer mentioned this in T366253: Create a generic stream to populate CirrusSearch weighted_tags.Aug 20 2024, 4:13 PM
pfischer updated the task description. (Show Details)Aug 20 2024, 4:27 PM
pfischer added a project: Growth-Team.Aug 21 2024, 3:55 PM
pfischer mentioned this in T372362: link-recommendations suggestions are not getting processed by Search infrastructure.Aug 22 2024, 12:16 PM
Michael subscribed.Aug 22 2024, 12:24 PM
pfischer changed the task status from Open to In Progress.Wed, Aug 28, 5:03 AM
pfischer moved this task from needs triage to Current work on the Discovery-Search board.
pfischer edited projects, added Discovery-Search (Current work); removed Discovery-Search.
pfischer moved this task from Incoming to In Progress on the Discovery-Search (Current work) board.
gerritbot added a comment.Wed, Aug 28, 9:58 AM

Change #1067928 had a related patch set uploaded (by Peter Fischer; author: Peter Fischer):

[mediawiki/extensions/CirrusSearch@master] Extract WeightedTagsBuilder.php

https://gerrit.wikimedia.org/r/1067928

gerritbot added a project: Patch-For-Review.Wed, Aug 28, 9:58 AM
gerritbot added a comment.Wed, Sep 4, 9:50 PM

Change #1070675 had a related patch set uploaded (by Peter Fischer; author: Peter Fischer):

[mediawiki/extensions/EventBus@wmf/1.43.0-wmf.21] Let PageEntitySerializer.canonicalPageURL accept PageReference

https://gerrit.wikimedia.org/r/1070675

gerritbot added a comment.Wed, Sep 4, 10:25 PM

Change #1070676 had a related patch set uploaded (by Peter Fischer; author: Peter Fischer):

[mediawiki/extensions/CirrusSearch@master] Extract WeightedTagsUpdater and add EventBusWeightedTagsUpdater implementation

https://gerrit.wikimedia.org/r/1070676

gmodena subscribed.Fri, Sep 6, 6:35 AM
gerritbot added a comment.Fri, Sep 6, 10:22 AM

Change #1071162 had a related patch set uploaded (by Peter Fischer; author: Peter Fischer):

[mediawiki/extensions/CirrusSearch@master] WeightedTagsUpdater: add support for trigger hint (rev_based flag)

https://gerrit.wikimedia.org/r/1071162

gerritbot added a comment.Fri, Sep 6, 3:39 PM

Change #1071233 had a related patch set uploaded (by Peter Fischer; author: Peter Fischer):

[mediawiki/extensions/GrowthExperiments@master] Use WeightedTagsUpdater

https://gerrit.wikimedia.org/r/1071233

pfischer claimed this task.Fri, Sep 6, 3:59 PM
pfischer moved this task from In Progress to Needs review on the Discovery-Search (Current work) board.
pfischer mentioned this in T374702: Cleanup: Remove deprecated weighted tag methods.Fri, Sep 13, 11:28 AM
gerritbot added a comment.Wed, Sep 18, 7:48 AM

Change #1067928 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Extract MultiListBuilder.php

https://gerrit.wikimedia.org/r/1067928

gerritbot added a comment.Wed, Sep 18, 7:54 AM

Change #1070676 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Extract WeightedTagsUpdater and add EventBusWeightedTagsUpdater implementation

https://gerrit.wikimedia.org/r/1070676

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.24; 2024-09-24).Wed, Sep 18, 8:00 AM
gerritbot added a comment.Wed, Sep 18, 8:17 AM

Change #1071162 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] WeightedTagsUpdater: add support for trigger hint (rev_based flag)

https://gerrit.wikimedia.org/r/1071162

pfischer moved this task from Needs review to To Be Deployed on the Discovery-Search (Current work) board.Wed, Sep 18, 2:26 PM
pfischer moved this task from To Be Deployed to Needs review on the Discovery-Search (Current work) board.Wed, Sep 18, 3:51 PM
pfischer added a subscriber: Urbanecm_WMF.

@Urbanecm_WMF, @Michael - CirrusSearch API changes are merged, so we can continue with migrating GrowthExperiments. There was one comment regarding resetting tags via hooks. Shall that be done as part of this CR?

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits