Description
Heretofore, references have been defined to allow not only ZIDs, but also external entities, such as QIDs and Lexeme IDs (LIDs) in Wikidata. In particular, isReference currently allows for any strings matching the following regex:
/^[A-JL-Z][1-9]\d*$/
Recently, we decided that references should not include external entities, so isReference should be redefined using:
/^Z[1-9]\d*$/
Update: we will leave isReference as is, but replace its uses with uses of a new function called isZObjectReference.
We might revisit this, fairly soon, if we choose to rework references, but we are starting to use Wikidata identifiers, and isReference needs to be updated for now to avoid errors, such as errors in canonicalization and normalization.
Tests that involve calls to isReference should be updated as needed.
Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)
- This should be done carefully so as not to change the system behavior, or introduce any new errors.
Remove all the non-applicable tags from the "Tags" field, leave only the tags of the projects/repositories related to this task
Completion checklist
- Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Back-end_Task/Bug_completion_checklist