Page MenuHomePhabricator
Create Task
Maniphest T374116

MPIC: Make Contextual attributes field optional
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Problem

The Metrics Platform documentation on WikiTech (specifically How to/Create First Metrics Platform Instrument) indicates that Contextual attributes are optional, while that is not indicated by the equivalent MPIC form field.

Suggested solution

Let's make the "Contextual attributes" field optional, and point this out by displaying an "Optional" field indicator next to its label.

Screenshot 2024-09-05 at 15.17.43.png (246×1 px, 33 KB)

Acceptance criteria

Details

SubjectRepoBranchLines +/-
MPIC: Deploying to production a new relase v0.2operations/deployment-chartsmaster+1 -1
MPIC: Deploying on staging a new relase v0.2operations/deployment-chartsmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Sarai-WMF created this task.Sep 5 2024, 1:21 PM
VirginiaPoundstone edited projects, added Experimentation Lab (Data Products Sprint 19); removed Experimentation Lab (Data products Sprint 18).Sep 5 2024, 7:03 PM
VirginiaPoundstone triaged this task as Medium priority.Sep 9 2024, 6:39 PM
Sfaci updated the task description. (Show Details)Sep 13 2024, 6:08 PM
Sfaci added a comment.Sep 13 2024, 6:15 PM

According to what we have discussed in slack (https://wikimedia.slack.com/archives/C05ERLBF0E7/p1726219102103249), I have updated the ACs for this ticket to include some agreements we made:

  • MPIC will add agent_client_platform_family by default (it's a mandatory contextual attribute) and consider the rest of contextual attributes as optional
  • Some information will be shown while registering an instrument to inform the user about this
• apaskulin mentioned this in T374742: Update Metrics Platform docs on required contextual attributes.Sep 13 2024, 9:37 PM
Sfaci claimed this task.Sep 16 2024, 6:23 PM
Sfaci moved this task from Sprint Backlog to In Process on the Experimentation Lab (Data Products Sprint 19) board.Sep 16 2024, 7:00 PM
Sfaci added a comment.Sep 17 2024, 8:23 AM

This work is included in the following MR that is ready for review: https://gitlab.wikimedia.org/repos/data-engineering/mpic/-/merge_requests/102

Sfaci reassigned this task from Sfaci to SGupta-WMF.Sep 17 2024, 8:32 AM
Sfaci set the point value for this task to 2.
Sfaci changed the point value for this task from 2 to 1.
Sfaci moved this task from In Process to Needs Review on the Experimentation Lab (Data Products Sprint 19) board.
Sfaci mentioned this in T374984: MPIC: Remove contextual attributes that are added automatically from MPIC UI when registering a new baseline instrument.Sep 17 2024, 4:34 PM
SGupta-WMF reassigned this task from SGupta-WMF to Sfaci.Sep 18 2024, 10:58 AM
SGupta-WMF subscribed.
Sfaci mentioned this in T375182: MPIC: Update unit/integration tests according to the new experiments routes.Sep 19 2024, 11:54 AM
Sfaci moved this task from Needs Review to To Deploy on the Experimentation Lab (Data Products Sprint 19) board.Sep 24 2024, 8:25 AM
Sfaci updated the task description. (Show Details)Sep 24 2024, 11:43 AM
gerritbot added a comment.Sep 24 2024, 12:08 PM

Change #1075207 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[operations/deployment-charts@master] MPIC: Deploying on staging a new relase v0.2

https://gerrit.wikimedia.org/r/1075207

gerritbot added a project: Patch-For-Review.Sep 24 2024, 12:08 PM
gerritbot added a comment.Sep 25 2024, 10:44 AM

Change #1075207 merged by jenkins-bot:

[operations/deployment-charts@master] MPIC: Deploying on staging a new relase v0.2

https://gerrit.wikimedia.org/r/1075207

gerritbot added a comment.Sep 25 2024, 10:50 AM

Change #1075524 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[operations/deployment-charts@master] MPIC: Deploying to production a new relase v0.2

https://gerrit.wikimedia.org/r/1075524

gerritbot added a comment.Sep 25 2024, 10:57 AM

Change #1075524 merged by jenkins-bot:

[operations/deployment-charts@master] MPIC: Deploying to production a new relase v0.2

https://gerrit.wikimedia.org/r/1075524

Maintenance_bot removed a project: Patch-For-Review.Sep 25 2024, 11:32 AM
Sfaci moved this task from To Deploy to Done on the Experimentation Lab (Data Products Sprint 19) board.Sep 25 2024, 12:24 PM
VirginiaPoundstone closed this task as Resolved.Oct 10 2024, 6:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits