InvalidArgumentException: Invalid IP address error when loading IPInfo logs
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Sep 11 2024, 11:05 AM

Project Tags

Referenced Files

None

Subscribers

Aklapper

Dreamy_Jazz

Description

Error

809d8893-f2c7-471b-8220-59a2c6ce2ddb

message

[{reqId}] {exception_url}   InvalidArgumentException: Invalid IP address

trace

from /srv/mediawiki/php-1.43.0-wmf.22/includes/user/UserFactory.php(130)
#0 /srv/mediawiki/php-1.43.0-wmf.22/extensions/IPInfo/src/Logging/IPInfoLogFormatter.php(43): MediaWiki\User\UserFactory->newAnonymous(string)
#1 /srv/mediawiki/php-1.43.0-wmf.22/includes/logging/LogFormatter.php(565): MediaWiki\IPInfo\Logging\IPInfoLogFormatter->getMessageParameters()
#2 /srv/mediawiki/php-1.43.0-wmf.22/includes/logging/LogFormatter.php(540): LogFormatter->getActionMessage()
#3 /srv/mediawiki/php-1.43.0-wmf.22/includes/logging/LogEventsList.php(342): LogFormatter->getActionText()
#4 /srv/mediawiki/php-1.43.0-wmf.22/includes/logging/LogPager.php(460): LogEventsList->logLine(stdClass)
#5 /srv/mediawiki/php-1.43.0-wmf.22/includes/pager/ReverseChronologicalPager.php(134): MediaWiki\Pager\LogPager->formatRow(stdClass)
#6 /srv/mediawiki/php-1.43.0-wmf.22/includes/pager/IndexPager.php(601): MediaWiki\Pager\ReverseChronologicalPager->getRow(stdClass)
#7 /srv/mediawiki/php-1.43.0-wmf.22/includes/specials/SpecialLog.php(317): MediaWiki\Pager\IndexPager->getBody()
#8 /srv/mediawiki/php-1.43.0-wmf.22/includes/specials/SpecialLog.php(195): MediaWiki\Specials\SpecialLog->show(MediaWiki\Html\FormOptions, array)
#9 /srv/mediawiki/php-1.43.0-wmf.22/includes/specialpage/SpecialPage.php(719): MediaWiki\Specials\SpecialLog->execute(null)
#10 /srv/mediawiki/php-1.43.0-wmf.22/includes/specialpage/SpecialPageFactory.php(1708): MediaWiki\SpecialPage\SpecialPage->run(null)
#11 /srv/mediawiki/php-1.43.0-wmf.22/includes/actions/ActionEntryPoint.php(502): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, MediaWiki\Context\RequestContext)
#12 /srv/mediawiki/php-1.43.0-wmf.22/includes/actions/ActionEntryPoint.php(145): MediaWiki\Actions\ActionEntryPoint->performRequest()
#13 /srv/mediawiki/php-1.43.0-wmf.22/includes/MediaWikiEntryPoint.php(200): MediaWiki\Actions\ActionEntryPoint->execute()
#14 /srv/mediawiki/php-1.43.0-wmf.22/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#15 /srv/mediawiki/w/index.php(3): require(string)
#16 {main}

Details

Related Changes in Gerrit:

Subject	Author	Repo	Branch	Lines +/-
Remove assumptions of IP info lookups targeting only anons	Máté Szabó	mediawiki/extensions/IPInfo	master	+100 -38
IPInfoLogFormatter: Avoid unnecessary User object creation	Dreamy Jazz	mediawiki/extensions/IPInfo	wmf/1.43.0-wmf.22	+21 -19
IPInfoLogFormatter: Avoid unnecessary User object creation	Máté Szabó	mediawiki/extensions/IPInfo	master	+21 -19

Customize query in gerrit

Related Objects

Mentioned In: T343492: Phase out SqlModuleDependencyStore
T374277: View full log does not work on wikis with language other than English
T374455: Create the "arbcom" user group on zhwiki
Mentioned Here: T343492: Phase out SqlModuleDependencyStore
T374277: View full log does not work on wikis with language other than English
T374455: Create the "arbcom" user group on zhwiki

Event Timeline

Dreamy_Jazz created this task.Sep 11 2024, 11:05 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 11 2024, 11:05 AM

Change #1072170 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] IPInfoLogFormatter: Avoid unnecessary User object creation

https://gerrit.wikimedia.org/r/1072170

gerritbot added a project: Patch-For-Review.Sep 11 2024, 11:21 AM

• mszabo changed the task status from Open to In Progress.Sep 11 2024, 11:26 AM

• mszabo claimed this task.

• mszabo added a project: Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)).

• mszabo moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)) board.

Change #1072176 had a related patch set uploaded (by Dreamy Jazz; author: Máté Szabó):

[mediawiki/extensions/IPInfo@wmf/1.43.0-wmf.22] IPInfoLogFormatter: Avoid unnecessary User object creation

https://gerrit.wikimedia.org/r/1072176

Change #1072170 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] IPInfoLogFormatter: Avoid unnecessary User object creation

https://gerrit.wikimedia.org/r/1072170

Change #1072181 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Remove assumptions of IP info lookups targeting only anons

https://gerrit.wikimedia.org/r/1072181

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.23; 2024-09-17).Sep 11 2024, 12:00 PM

Change #1072176 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@wmf/1.43.0-wmf.22] IPInfoLogFormatter: Avoid unnecessary User object creation

https://gerrit.wikimedia.org/r/1072176

Mentioned in SAL (#wikimedia-operations) [2024-09-11T13:27:41Z] <dreamyjazz@deploy1003> Started scap sync-world: Backport for [[gerrit:1071838|Remove ResourceLoaderUseObjectCacheForDeps (T343492)]], [[gerrit:1072159|Generate special page name in English for central URLs (T374277)]], [[gerrit:1072176|IPInfoLogFormatter: Avoid unnecessary User object creation (T374526)]], [[gerrit:1071902|Add arbcom group to zhwiki (T374455)]], [[gerrit:1072177|Remove redundant oathauth-enable flag (

Stashbot mentioned this in T343492: Phase out SqlModuleDependencyStore.Sep 11 2024, 1:27 PM

Mentioned in SAL (#wikimedia-operations) [2024-09-11T13:29:49Z] <dreamyjazz@deploy1003> jdrewniak, hokwelum, dreamyjazz, hamishz: Backport for [[gerrit:1071838|Remove ResourceLoaderUseObjectCacheForDeps (T343492)]], [[gerrit:1072159|Generate special page name in English for central URLs (T374277)]], [[gerrit:1072176|IPInfoLogFormatter: Avoid unnecessary User object creation (T374526)]], [[gerrit:1071902|Add arbcom group to zhwiki (T374455)]], [[gerrit:1072177|Remove redundant oatha

Mentioned in SAL (#wikimedia-operations) [2024-09-11T13:40:51Z] <dreamyjazz@deploy1003> Finished scap sync-world: Backport for [[gerrit:1071838|Remove ResourceLoaderUseObjectCacheForDeps (T343492)]], [[gerrit:1072159|Generate special page name in English for central URLs (T374277)]], [[gerrit:1072176|IPInfoLogFormatter: Avoid unnecessary User object creation (T374526)]], [[gerrit:1071902|Add arbcom group to zhwiki (T374455)]], [[gerrit:1072177|Remove redundant oathauth-enable flag