Page MenuHomePhabricator
Create Task
Maniphest T375178

MetricsPlatform always fetches instrument configs
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

In order to minimize the amount of work done by both the appservers and MPIC, instrument configs should only be fetched when dynamic event stream config creation is enabled ($wgMetricsPlatformEnableStreamConfigsMerging is truthy). However, instrument configs are always fetched.

AC

  • When $wgMetricsPlatformEnableStreamConfigsMerging is falsy, instrument configs shouldn't be fetched

Details

SubjectRepoBranchLines +/-
Hooks: Honor $wgMetricsPlatformEnableStreamConfigsMergingmediawiki/extensions/MetricsPlatformmaster+16 -11
Customize query in gerrit

Related Objects

Event Timeline

phuedx created this task.Sep 19 2024, 11:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 19 2024, 11:42 AM
phuedx triaged this task as High priority.Sep 19 2024, 11:42 AM
gerritbot added a comment.Sep 19 2024, 11:43 AM

Change #1074144 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/MetricsPlatform@master] Hooks: Honor $wgMetricsPlatformEnableStreamConfigsMerging

https://gerrit.wikimedia.org/r/1074144

gerritbot added a project: Patch-For-Review.Sep 19 2024, 11:43 AM
phuedx claimed this task.Sep 19 2024, 11:43 AM
phuedx moved this task from In Process to Needs Review on the Experimentation Lab (Data Products Sprint 19) board.
phuedx updated the task description. (Show Details)Sep 26 2024, 11:05 AM
phuedx moved this task from Needs Review to Sign Off on the Experimentation Lab (Data Products Sprint 19) board.
gerritbot added a comment.Sep 26 2024, 12:52 PM

Change #1074144 merged by jenkins-bot:

[mediawiki/extensions/MetricsPlatform@master] Hooks: Honor $wgMetricsPlatformEnableStreamConfigsMerging

https://gerrit.wikimedia.org/r/1074144

phuedx mentioned this in rEMPLf195edbdac95: Hooks: Honor $wgMetricsPlatformEnableStreamConfigsMerging.Sep 26 2024, 12:59 PM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.25; 2024-10-01).Sep 26 2024, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 26 2024, 1:31 PM
phuedx moved this task from Sign Off to To Deploy on the Experimentation Lab (Data Products Sprint 19) board.Sep 26 2024, 4:01 PM
VirginiaPoundstone edited projects, added Experimentation Lab (Data Products Sprint 20 🎯); removed Experimentation Lab (Data Products Sprint 19).Sep 27 2024, 3:01 PM
VirginiaPoundstone moved this task from Sprint Backlog to To Deploy on the Experimentation Lab (Data Products Sprint 20 🎯) board.
Milimetric set the point value for this task to 2.Oct 3 2024, 11:05 AM
phuedx moved this task from To Deploy to Sign Off on the Experimentation Lab (Data Products Sprint 20 🎯) board.Oct 9 2024, 12:33 PM
phuedx moved this task from Sign Off to Done on the Experimentation Lab (Data Products Sprint 20 🎯) board.Oct 11 2024, 5:08 PM
VirginiaPoundstone closed this task as Resolved.Nov 7 2024, 8:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits