parameter_functions.py
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Sep 24 2024, 5:10 PM

Description

(I wouldn't be surprised if this actually a dupe)

It's annoying maintaining lists of things that are subject to line length, need reordering.. Potentially breaking git blame etc.

And fighting with errors like

18:01:44 ./zuul/parameter_functions.py:624:80: E501 line too long (83 > 79 characters)
18:01:44 ERROR: InvocationError for command /src/.tox/lint/bin/flake8 (exited with code 1)

Rather than having this in python, and putting everything on individual lines (increasing the python file length further)...

'AbuseFilter': ['AntiSpoof', 'CentralAuth', 'CodeEditor',
                'CheckUser', 'ConfirmEdit', 'Echo',
                'Renameuser', 'Scribunto', 'EventLogging'],

We can have something like

'AbuseFilter': [
    'AntiSpoof',
    'CentralAuth',
    'CodeEditor',
    'CheckUser',
    'ConfirmEdit',
    'Echo',
    'Renameuser',
    'Scribunto',
    'EventLogging'
],

AbuseFilter:
 - AntiSpoof
 - CentralAuth
 - CodeEditor
 - CheckUser
 - ConfirmEdit
 - Echo
 - Renameuser
 - Scribunto
 - EventLogging

Details

	Subject	Repo	Branch	Lines +/-
	Zuul: Split out deps and phan_deps to YAML files	integration/config	master	+1 K -671

Customize query in gerrit

Event Timeline

Reedy created this task.Sep 24 2024, 5:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 24 2024, 5:10 PM

Reedy updated the task description. (Show Details)Sep 24 2024, 5:12 PM

Jdforrester-WMF added a project: Continuous-Integration-Infrastructure.Sep 24 2024, 5:12 PM

Reedy updated the task description. (Show Details)Sep 24 2024, 5:14 PM

Reedy updated the task description. (Show Details)

Maybe even reusing layout.yaml may make sense...

Change #1075279 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: Split out deps and phan_deps to YAML files

https://gerrit.wikimedia.org/r/1075279

gerritbot added a project: Patch-For-Review.Sep 24 2024, 5:46 PM

Change #1075279 merged by jenkins-bot:

[integration/config@master] Zuul: Split out deps and phan_deps to YAML files

https://gerrit.wikimedia.org/r/1075279

Mentioned in SAL (#wikimedia-releng) [2024-09-24T19:58:13Z] <James_F> Zuul: Split out deps and phan_deps to YAML files, for T375541

Maintenance_bot removed a project: Patch-For-Review.Sep 24 2024, 8:31 PM

Jdforrester-WMF closed this task as Resolved.Sep 24 2024, 10:17 PM

Jdforrester-WMF claimed this task.

Lucas_Werkmeister_WMDE awarded a token.Sep 25 2024, 8:44 AM

Move `dependencies` and `phan_dependencies` to separate YAML/JSON file from zuul/parameter_functions.pyClosed, ResolvedPublicActions

Description

Details

Event Timeline

Move `dependencies` and `phan_dependencies` to separate YAML/JSON file from zuul/parameter_functions.py
Closed, ResolvedPublic
Actions