Page MenuHomePhabricator

Deploy Vector 2022 as default to various sites
Closed, ResolvedPublic2 Estimated Story Points

Assigned To
Authored By
Jdlrobson
Sep 24 2024, 6:37 PM
Referenced Files
F57609317: pl.wikimedia.org.png
Oct 13 2024, 2:40 AM
F57609315: be.wikimedia.org.png
Oct 13 2024, 2:40 AM
F57609313: wb.wikimedia.org.png
Oct 13 2024, 2:40 AM
F57599789: screenshot 54.png
Oct 9 2024, 2:25 AM
F57599785: screenshot 53.png
Oct 9 2024, 2:25 AM
F57599780: screenshot 52.png
Oct 9 2024, 2:25 AM
F57599771: screenshot 50.png
Oct 9 2024, 2:25 AM
F57599751: screenshot 49.png
Oct 9 2024, 2:25 AM

Description

Background

We will expand Vector 2022 roll out to more wikis.

Requirements

  • Add logo variants for sh and shi wikipedia - see QA steps for details on testing.
  • The following wikis should get Vector 2022
  • sh.wikipedia.org
  • shi.wikipedia.org
  • bd.wikimedia.org
  • cn.wikimedia.org
  • hi.wikimedia.org
  • mai.wikimedia.org
  • punjabi.wikimedia.org
  • wb.wikimedia.org
  • se.wikimedia.org
  • pt.wikimedia.org
  • be.wikimedia.org
  • am.wikimedia.org
  • dk.wikimedia.org
  • rom.wikimedia.org
  • il.wikimedia.org
  • pl.wikimedia.org
  • gr.wikimedia.org
  • et.wikimedia.org
  • steward.wikimedia.org
  • otrs-wiki.wikimedia.org
  • ombuds.wikimedia.org
  • checkuser.wikimedia.org
BDD
Feature: Deploy Vector 2022 and Verify Logo Display for sh and shi Wikipedia

  Scenario: Verify Vector 2022 is the default skin
    Given the user visits a specified wiki in an incognito window
    When the page is loaded
    Then the wiki should default to Vector 2022

  Scenario: Display correct logo for sh Wikipedia
    Given the user visits sh.wikipedia.org
    When the user selects the Latin script variant
    Then the logo should appear in Latin script

  Scenario: Display correct non-Latin logo for sh Wikipedia
    Given the user visits sh.wikipedia.org
    When the user selects the non-Latin script variant
    Then the logo should appear in non-Latin script

  Scenario: Display correct logo for shi Wikipedia (Latin)
    Given the user visits shi.wikipedia.org
    When the user selects the Latin script variant
    Then the logo should appear in Latin script

  Scenario: Display correct non-Latin logo for shi Wikipedia
    Given the user visits shi.wikipedia.org
    When the user selects the non-Latin script variant
    Then the logo should appear in non-Latin script

  Scenario: Display correct Tifinagh logo for shi Wikipedia
    Given the user visits shi.wikipedia.org
    When the user selects the Tifinagh script variant
    Then the logo should appear in Tifinagh script​⬤

Test Steps

Design

We need the following logos in wordmark and tagline form for non-latin scripts:
https://shi.wikipedia.org/static/images/project-logos/shiwiki.png
https://shi.wikipedia.org/static/images/project-logos/shwiki.png

Acceptance criteria

$wgLogos = [
	'wordmark' => [
		'src' => "https://en.m.wikipedia.org/static/images/mobile/copyright/wikipedia-wordmark-sh-latn.svg",
		'width' => 120,
		'height' => 18,
	],
	'variants' => [
		'sh-cyrl' => [
			'wordmark' => [
                               /* this image already exists */
				'src' => "https://en.m.wikipedia.org/static/images/mobile/copyright/wikipedia-wordmark-sh.svg",
				'width' => 124,
				'height' => 20,
			],
		]
	],
	'tagline' =>  [
		'src' => "https://en.m.wikipedia.org/static/images/mobile/copyright/wikipedia-tagline-en.svg",
		'width' => 117,
		'height' => 13,
	],
];

Communication criteria - does this need an announcement or discussion?

  • Add communication criteria

Rollback plan

  • What is the rollback plan in production for this task if something goes wrong?

This task was created by Version 1.2.0 of the Web team task template using phabulous

Event Timeline

Jdlrobson renamed this task from Deploy Vector 2022 as default to Deploy Vector 2022 as default to various skins.Sep 24 2024, 6:59 PM
Izno renamed this task from Deploy Vector 2022 as default to various skins to Deploy Vector 2022 as default to various sites.Sep 24 2024, 8:14 PM

@JScherer-WMF would you be able to generate the 2 taglines and 2 wordmarks we need for this (latin script only)?

"Wikipidya" and "Asamu ilelli" seems to be the text for shi.wikipedia.org https://shi.wikipedia.org/wiki/Wikipidya
"Wikipedija" and "Slobodna enciklopedija" for sh.wikipedia.org

Change #1078454 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Expand Vector 2022 roll out

https://gerrit.wikimedia.org/r/1078454

2 logos are oustanding here, will move out of blocked when available

JScherer-WMF subscribed.

These should unblock you @Jdlrobson. Let me know if you need anything else.

This comment was removed by Ebrahim.

Change #1078454 merged by jenkins-bot:

[operations/mediawiki-config@master] Expand Vector 2022 roll out and support local variants

https://gerrit.wikimedia.org/r/1078454

Mentioned in SAL (#wikimedia-operations) [2024-10-08T20:10:14Z] <cjming@deploy2002> Started scap sync-world: Backport for [[gerrit:1078454|Expand Vector 2022 roll out and support local variants (T375549)]]

Mentioned in SAL (#wikimedia-operations) [2024-10-08T20:12:38Z] <cjming@deploy2002> jdlrobson, cjming: Backport for [[gerrit:1078454|Expand Vector 2022 roll out and support local variants (T375549)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Jdlrobson lowered the priority of this task from High to Medium.

Mentioned in SAL (#wikimedia-operations) [2024-10-08T20:29:42Z] <cjming@deploy2002> Finished scap sync-world: Backport for [[gerrit:1078454|Expand Vector 2022 roll out and support local variants (T375549)]] (duration: 19m 28s)

Edtadros subscribed.

Test Result - Prod

Status: ❌ FAIL
Environment: see below
OS: macOS
Browser: Chrome
Device: MS MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify Vector 2022 and Logo Display on Various Wikis

  1. AC1: All wikis above default to Vector 2022 in an incognito window.
#URLValidationStatusScreenshot
1https://sh.wikipedia.org"skin-vector-2022 in body tag"
sh.wikipedia.org.png (3×800 px, 962 KB)
2https://shi.wikipedia.org"skin-vector-2022 in body tag"
shi.wikipedia.org.png (5×800 px, 948 KB)
3https://bd.wikimedia.org"skin-vector-2022 in body tag"
bd.wikimedia.org.png (1×888 px, 390 KB)
4https://cn.wikimedia.org"skin-vector-2022 in body tag"
cn.wikimedia.org.png (1×800 px, 331 KB)
5https://hi.wikimedia.org"skin-vector-2022 in body tag"
hi.wikimedia.org.png (3×906 px, 658 KB)
6https://mai.wikimedia.org"skin-vector-2022 in body tag"
mai.wikimedia.org.png (3×800 px, 2 MB)
7https://punjabi.wikimedia.org"skin-vector-2022 in body tag"
punjabi.wikimedia.org.png (600×800 px, 38 KB)
8https://wb.wikimedia.org"skin-vector-2022 in body tag"
wb.wikimedia.org.png (3×910 px, 1 MB)
9https://se.wikimedia.org"skin-vector-2022 in body tag"
se.wikimedia.org.png (2×800 px, 714 KB)
10https://pt.wikimedia.org"skin-vector-2022 in body tag"
pt.wikimedia.org.png (1×800 px, 292 KB)
11https://be.wikimedia.org"skin-vector-2022 in body tag"
be.wikimedia.org.png (3×800 px, 797 KB)
12https://am.wikimedia.org"skin-vector-2022 in body tag"
am.wikimedia.org.png (3×842 px, 609 KB)
13https://dk.wikimedia.org"skin-vector-2022 in body tag"
dk.wikimedia.org.png (2×800 px, 718 KB)
14https://rom.wikimedia.org"skin-vector-2022 in body tag"This doesn't appear to exist.
screenshot 48.png (1×1 px, 156 KB)
15https://il.wikimedia.org"skin-vector-2022 in body tag"
il.wikimedia.org.png (600×800 px, 65 KB)
16https://pl.wikimedia.org"skin-vector-2022 in body tag"
pl.wikimedia.org.png (3×800 px, 882 KB)
17https://gr.wikimedia.org"skin-vector-2022 in body tag"
gr.wikimedia.org.png (2×852 px, 505 KB)
18https://et.wikimedia.org"skin-vector-2022 in body tag"
et.wikimedia.org.png (1×800 px, 272 KB)
19https://steward.wikimedia.org"skin-vector-2022 in body tag"
steward.wikimedia.org.png (726×800 px, 98 KB)
20https://otrs-wiki.wikimedia.org"skin-vector-2022 in body tag"
otrs-wiki.wikimedia.org.png (846×800 px, 147 KB)
21https://ombuds.wikimedia.org"skin-vector-2022 in body tag"
ombuds.wikimedia.org.png (756×800 px, 99 KB)
22https://checkuser.wikimedia.org"skin-vector-2022 in body tag"
checkuser.wikimedia.org.png (664×800 px, 91 KB)

The ACs below are a pass per T375549#10215753

  1. AC2: Visiting https://sh.wikipedia.org/w/index.php?title=Glavna_stranica&variant=sh-latn I should see the logo in a latin script

I'm not sure what the different script variants are, but the tagline font is not clear.

screenshot 49.png (1×1 px, 556 KB)

  1. AC3 Visiting https://sh.wikipedia.org/w/index.php?title=Glavna_stranica&variant=sh-cyrl I should see the logo in non-latin script

I'm not sure what the different script variants are, but the tagline font is not clear.

screenshot 50.png (1×1 px, 555 KB)

  1. AC4: Visiting https://shi.wikipedia.org/w/index.php?title=Tasna_Tamzwarut&variant=shi-latn I should see the logo in a latin script

I'm not sure what the different script variants are, but the tagline font is not clear.

screenshot 52.png (1×1 px, 384 KB)

  1. AC5: Visiting https://shi.wikipedia.org/w/index.php?title=Tasna_Tamzwarut&variant=shi I should see the logo in non-latin script

I'm not sure what the different script variants are, but the tagline font is not clear.

screenshot 53.png (1×1 px, 480 KB)

  1. AC6: Visiting https://shi.wikipedia.org/w/index.php?title=Tasna_Tamzwarut&variant=shi-tfngI should see the logo in non-latin script.

screenshot 54.png (1×1 px, 474 KB)

Could you repeat the failures - looks like thse related to caching. These are now updated.

AC2
AC5
AC5
AC6:

These are passes.

Test Result - Prod

Status: ❌ FAIL
Environment: see below
OS: macOS
Browser: Chrome
Device: MS MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify Vector 2022 and Logo Display on Various Wikis

  1. AC1: All wikis above default to Vector 2022 in an incognito window.
#URLValidationStatusScreenshot
8https://wb.wikipedia.org"skin-vector-2022 in body tag"
wb.wikimedia.org.png (3×800 px, 1 MB)
11https://be.wikipedia.org"skin-vector-2022 in body tag"This still fails, it seems as though the main page doesn't want to be in Vector2022, but other pages default to it.
be.wikimedia.org.png (3×800 px, 797 KB)
14https://rom.wikipedia.org"skin-vector-2022 in body tag"This still appears to not be a valid wiki, do you mean ro or rom?
16https://pl.wikipedia.org"skin-vector-2022 in body tag"
pl.wikimedia.org.png (4×1 px, 953 KB)

AC2 through AC6 have been updated in T375549#10212947 to a ✅ PASS per T375549#10215753 above.

be.wikimedia.org is working now. Looks like the other domain was meant to be romdwikimedia. I'd do that in a separate ticket.

Follow up posted in T377238: Enable vector 2022 on romd Wikimedia