Page MenuHomePhabricator

Regression: Bottom margin not applying to h2s in Parsoid
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

No bottom margin for h2s - wrong selector. Nothing matches mw-parser-output > section > section > .mw-heading2 selector.

What should have happened instead?:

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Requirement

Ensure that the correct bottom margin is applied to <h2> elements in Parsoid-rendered pages. Currently, no bottom margin is being applied due to a mismatched selector. The margin should appear on both Parsoid and non-Parsoid pages.

BDD

Feature: Bottom Margin for h2 Elements in Parsoid

  Scenario: Correct bottom margin applied to h2 elements in Parsoid
    Given the user visits a Parsoid-rendered page
    When the page is loaded
    Then the bottom margin should be applied to all `<h2>` elements
    And the same margin should be visible in non-Parsoid pages

Test Steps

Test Case 1: Verify Bottom Margin for h2 in Parsoid and Non-Parsoid Pages

  1. Visit this Parsoid page and compare it with this non-Parsoid page.
  2. AC1: Confirm that a bottom margin is applied to <h2> elements on both the Parsoid and non-Parsoid pages.

QA Results - Beta

ACStatusDetails
1T375822#10203608

QA Results - Prod

ACStatusDetails
1T375822#10203617

Event Timeline

Change #1076035 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Bottom margin not applying to Parsoid H2s

https://gerrit.wikimedia.org/r/1076035

Change #1076036 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[integration/visualdiff@master] Workaround for bug T375822

https://gerrit.wikimedia.org/r/1076036

Jdlrobson triaged this task as Medium priority.Sep 26 2024, 9:42 PM

Change #1076036 merged by jenkins-bot:

[integration/visualdiff@master] MFE: Workaround for bug T375822

https://gerrit.wikimedia.org/r/1076036

Jdlrobson renamed this task from Bottom margin not applying to h2s in Parsoid to Regression: Bottom margin not applying to h2s in Parsoid.Sep 27 2024, 5:24 PM
Jdlrobson assigned this task to ovasileva.
Jdlrobson reassigned this task from ovasileva to Edtadros.
Jdlrobson added a subscriber: ovasileva.

Change #1076035 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Bottom margin not applying to Parsoid H2s

https://gerrit.wikimedia.org/r/1076035

Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS
Browser: Chrome
Device: MS MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify Bottom Margin for h2 in Parsoid and Non-Parsoid Pages

  1. Visit this Parsoid page and compare it with this non-Parsoid page. For Beta, this Parsoid page and this non-Parsoid page.
  2. AC1: Confirm that a bottom margin is applied to <h2> elements on both the Parsoid and non-Parsoid pages.
Parsoidnon-Parsoid
screenshot 35.png (781×1 px, 157 KB)
screenshot 37.png (782×1 px, 161 KB)

Test Result - Prod

Status: ✅ PASS
Environment: enwikivoyage
OS: macOS
Browser: Chrome
Device: MS MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify Bottom Margin for h2 in Parsoid and Non-Parsoid Pages

  1. Visit this Parsoid page and compare it with this non-Parsoid page. For Beta, this Parsoid page and this non-Parsoid page.
  2. AC1: Confirm that a bottom margin is applied to <h2> elements on both the Parsoid and non-Parsoid pages.
Parsoidnon-Parsoid
screenshot 39.png (877×1 px, 230 KB)
screenshot 38.png (883×1 px, 218 KB)
Jdlrobson claimed this task.

LGTM