Page MenuHomePhabricator
Create Task
Maniphest T375922

enable tracing data into services
Closed, ResolvedPublic
Actions

Description

What/Why:
We have a tracing dashboard that shows traces per API call, but we would benefit a ton if we could see deeper down the call, into each service layer, orchestrator and evaluator. With those spans added, we would be able to see how long we take there and any issues that arise within.

How:
We use the TelemetryHeadersInterface in the PHP layer but is there a way we can instrument this in our backend services too? There is a initAndLogRequest function in both services I think we can add the tracing headers to...

Details

SubjectRepoBranchLines +/-
wikifunctions: Upgrade orchestrator from 2024-10-15-192817 to 2024-11-13-145636operations/deployment-chartsmaster+1 -1
wikifunctions: Upgrade evaluators from 2024-10-08-175510 to 2024-10-10-202633operations/deployment-chartsmaster+2 -2
wikifunctions: Upgrade orchestrator from 2024-10-08-175830 to 2024-10-15-192817operations/deployment-chartsmaster+1 -1
Use OTel headersmediawiki/extensions/WikiLambdamaster+2 -14
Customize query in gerrit

Related Objects
Search...

Event Timeline

ecarg created this task.Sep 27 2024, 6:59 PM
CodeReviewBot added a project: Patch-For-Review.Sep 27 2024, 7:04 PM

ecarg opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/238

add trace headers

CodeReviewBot added a comment.Sep 27 2024, 7:09 PM

ecarg opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/261

add trace headers

gerritbot added a comment.Sep 27 2024, 8:15 PM

Change #1076260 had a related patch set uploaded (by Ecarg; author: Ecarg):

[mediawiki/extensions/WikiLambda@master] use OTel to prefill req headers

https://gerrit.wikimedia.org/r/1076260

Sharvaniharan moved this task from To Triage to 25Q2 (Oct–Dec) on the Abstract Wikipedia team board.Oct 2 2024, 4:34 PM
Sharvaniharan edited projects, added Abstract Wikipedia team (25Q2 (Oct–Dec)); removed Abstract Wikipedia team.
Sharvaniharan triaged this task as Medium priority.Oct 2 2024, 4:39 PM
Sharvaniharan moved this task from Incoming to Ready, Features on the Abstract Wikipedia team (25Q2 (Oct–Dec)) board.
gerritbot added a comment.Oct 8 2024, 8:15 PM

Change #1076260 had a related patch set uploaded (by Ecarg; author: Ecarg):

[mediawiki/extensions/WikiLambda@master] Bug: T375922 Change-Id: I7247907b218cbb26f93299caee0904c2d29e501f

https://gerrit.wikimedia.org/r/1076260

CodeReviewBot added a comment.Oct 8 2024, 8:34 PM

ecarg closed https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/261

Draft: add trace headers

CodeReviewBot added a comment.Oct 8 2024, 8:35 PM

ecarg closed https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/238

Draft: add trace headers

CodeReviewBot added a comment.Oct 8 2024, 8:37 PM

ecarg opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/241

Add telemetry headers

CodeReviewBot added a comment.Oct 8 2024, 8:37 PM

ecarg opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/264

Add telemetry headers

Jdforrester-WMF moved this task from Ready, Features to In Engineering on the Abstract Wikipedia team (25Q2 (Oct–Dec)) board.Oct 9 2024, 7:19 PM
Jdforrester-WMF moved this task from In Engineering to In Code review on the Abstract Wikipedia team (25Q2 (Oct–Dec)) board.
CodeReviewBot added a comment.Oct 10 2024, 7:12 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/264

Add telemetry headers

CodeReviewBot added a comment.Oct 10 2024, 7:12 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/241

Add telemetry headers

gerritbot added a comment.Oct 10 2024, 7:38 PM

Change #1076260 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Use OTel headers

https://gerrit.wikimedia.org/r/1076260

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.27; 2024-10-15).Oct 10 2024, 8:00 PM
gerritbot added a comment.Oct 15 2024, 7:52 PM

Change #1080367 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-10-08-175830 to 2024-10-15-192817

https://gerrit.wikimedia.org/r/1080367

gerritbot added a comment.Oct 15 2024, 7:52 PM

Change #1080368 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-10-08-175510 to 2024-10-10-202633

https://gerrit.wikimedia.org/r/1080368

gerritbot added a comment.Oct 15 2024, 7:54 PM

Change #1080367 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-10-08-175830 to 2024-10-15-192817

https://gerrit.wikimedia.org/r/1080367

Jdforrester-WMF moved this task from In Code review to Needs Sign-off on the Abstract Wikipedia team (25Q2 (Oct–Dec)) board.Oct 15 2024, 8:02 PM
gerritbot added a comment.Oct 15 2024, 8:02 PM

Change #1080368 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-10-08-175510 to 2024-10-10-202633

https://gerrit.wikimedia.org/r/1080368

CodeReviewBot added a comment.Oct 18 2024, 5:59 PM

ecarg opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/244

trace headers cont

ecarg changed the task status from Open to In Progress.Nov 1 2024, 5:25 PM
ecarg added a parent task: T376664: [25Q2] Add alert monitoring for Wikifunctions services.
CodeReviewBot added a comment.Nov 5 2024, 1:11 AM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/244

pass header details for tracing from evaluator

Jdforrester-WMF moved this task from Needs Sign-off to Ready to deploy on the Abstract Wikipedia team (25Q2 (Oct–Dec)) board.Nov 12 2024, 7:49 PM
gerritbot added a comment.Nov 13 2024, 4:27 PM

Change #1090892 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-10-15-192817 to 2024-11-13-145636

https://gerrit.wikimedia.org/r/1090892

gerritbot added a comment.Nov 13 2024, 10:02 PM

Change #1090892 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-10-15-192817 to 2024-11-13-145636

https://gerrit.wikimedia.org/r/1090892

Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (25Q2 (Oct–Dec)) board.Nov 13 2024, 10:27 PM
ecarg closed this task as Resolved.Nov 14 2024, 8:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits