Page MenuHomePhabricator

Allow autoblocks on IP addresses in the globalblocks table for IP addresses which are already globally blocked
Closed, ResolvedPublic2 Estimated Story Points

Description

The globalblocks table has an index named gb_address which is used to lookup by target and also enforce uniqueness. However, to allow global autoblocks (T368949) we need to be able to have both an autoblock and non-autoblock target the same IP address.

This brings feature parity with core, which allows an IP to be both autoblocked and blocked directly. This also is necessary because it would be easy to determine the target of an autoblock if it gets removed for clashing with a global block on an IP address.

Therefore, the gb_address index needs to be updated to allow rows with the same target but where one is an autoblock and the other is not.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1076805 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Update globalblocks 'gb_address' index to allow autoblocks

https://gerrit.wikimedia.org/r/1076805

Change #1076805 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Update globalblocks 'gb_address' index to allow autoblocks

https://gerrit.wikimedia.org/r/1076805

The associated schema change has been performed on WMF wikis and this task does not need QA, as such closing this.

Change #1078406 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@wmf/1.43.0-wmf.25] Update globalblocks 'gb_address' index to allow autoblocks

https://gerrit.wikimedia.org/r/1078406

Change #1078406 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@wmf/1.43.0-wmf.25] Update globalblocks 'gb_address' index to allow autoblocks

https://gerrit.wikimedia.org/r/1078406

Mentioned in SAL (#wikimedia-operations) [2024-10-07T13:28:54Z] <dreamyjazz@deploy2002> Started scap sync-world: Backport for [[gerrit:1078406|Update globalblocks 'gb_address' index to allow autoblocks (T376052)]]

Mentioned in SAL (#wikimedia-operations) [2024-10-07T13:30:52Z] <dreamyjazz@deploy2002> dreamyjazz: Backport for [[gerrit:1078406|Update globalblocks 'gb_address' index to allow autoblocks (T376052)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-10-07T13:35:43Z] <dreamyjazz@deploy2002> Finished scap sync-world: Backport for [[gerrit:1078406|Update globalblocks 'gb_address' index to allow autoblocks (T376052)]] (duration: 06m 49s)