There have been requests to also change the position of the notification, and instead have it be a dialog in the middle of the page so it's easier to see. Do you think that'd be a good change?

Note that in T364664 we've just changed edit recovery to be ask-to-recover instead of ask-to-undo-recovery, so that might change how the close process should work.

I'm not sure that adding a close icon just to this one use of the bubble notification would make sense; if anything they should all get it. Although I guess some are different in that they have other buttons in them, which many don't.

Anyway, if we switch to a central dialog then it's easy to add a close button (Codex dialogs have an X built in).

Thanks @Samwilson! I think switching to a central dialog could be a solution but let's see if T364664 changes anything. I will check with the huwiki community after it is deployed and report back.

Codex dialogs are modal, i.e. you can’t do anything on the page before you interact with them. If T364664 was the right decision, and most of the time people don’t want to recover changes, using a modal popup would make their lives more difficult – currently, if you don’t want to interact with the recovery notification, you can just start editing and ignore it; this would not be possible with a modal version.

Yeah, I agree, and I think that's why we didn't do it in the beginning.

Regarding adding a close button to the button notification, should we go ahead with that? Would clicking elsewhere in the notification still close it as it does now? Another option is to enable autoHide (it's currently disabled), so the notification disappears after 5 seconds.

In T376105#10214139, @Samwilson wrote:

Regarding adding a close button to the button notification, should we go ahead with that? Would clicking elsewhere in the notification still close it as it does now?

MediaWiki-extensions-ParserMigration adds an X icon to the notification, but it doesn’t do anything with it: it’s there, you can press that to close the notification, but you can equally press anything else, since the hiding is still handled the same way as for any other notification. I don’t particularly like it (especially as it tries to combine Codex notices with mw.notify, which is visually not very pleasing IMHO), but not being able to press anything in the popup would in turn cause usability issues (fat finger problem), and inventing yet another way how notifications work is confusing anyway.

Another option is to enable autoHide (it's currently disabled), so the notification disappears after 5 seconds.

I definitely wouldn’t do this: if the notification is gone, the possibility to restore the changes is also gone, forever (you wrote in T364664#10220411 that it’s expected that the next page load doesn’t let the user restore anymore).