Page MenuHomePhabricator

parserTests.php doesn't like git
Closed, ResolvedPublic

Description

tests/parserTests.php works in a svn checkout
http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3?view=log

But it fails in git, even on 4b8e45d60472ae6a0b5c4ad8728a476ad530519b (r114354)

It stops with:

A database error has occurred. Did you forget to run maintenance/update.php after upgrading? See: https://www.mediawiki.org/wiki/Manual:Upgrading#Run_the_update_script
Query: DELETE FROM parsertest_objectcache WHERE keyname = 'my_wiki-parsertest_:messages:aa'
Function: SqlBagOStuff::delete
Error: 1146 Table 'my_wiki.parsertest_objectcache' doesn't exist (localhost)

It's the old bug of DB_CACHE being chosen for DB_ANYTHING before it's replaced by parserTest.inc:792


Version: 1.19
Severity: normal

Details

Reference
bz35648

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:17 AM
bzimport set Reference to bz35648.

It was doing through a different path in svn.
SpecialVersion::getVersion() called wfMsg(), which used the SqlBagOStuff before the DB cloning.

So it had been broken for a long time outside a svn checkout.

Added a fix in https://gerrit.wikimedia.org/r/4111

I have sent a friendly remember to Platonides.

AFAIUI, this has been fixed by gerrit change 3962. Please re-open otherwise.