Page MenuHomePhabricator
Create Task
Maniphest T376491

[Regression] Minerva on desktop missing notification icons
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
ovasileva
Authored By
Jdrewniak
Oct 4 2024, 5:03 PM
Tags
Referenced Files
F57615138: screenshot 94.png
Oct 15 2024, 1:46 AM
F57601797: 2024-10-09_11-40-22.png
Oct 9 2024, 7:19 PM
F57588911: Screenshot 2024-10-04 at 1.00.57 PM.png
Oct 4 2024, 5:03 PM
F57588909: Screenshot 2024-10-04 at 1.01.26 PM.png
Oct 4 2024, 5:03 PM
Subscribers
Aklapper
Edtadros
GMikesell-WMF
Jdlrobson
Jdrewniak

Description

Steps to reproduce

  1. Log in on a wiki
  2. Visit a page on desktop, using the Minerva skin: https://en.wikipedia.org/wiki/Olmec_colossal_heads?useskin=minerva

Expected results

  • There should be a bell icon and a tray icon for notifications

Screenshot 2024-10-04 at 1.01.26 PM.png (1×1 px, 979 KB)

Actual results

  • There is no bell, and there is no tray.

Screenshot 2024-10-04 at 1.00.57 PM.png (1×1 px, 979 KB)

Environments observed

Any browser, only using the desktop version of the MinervaNeue skin

Check any additional observations

Derived Requirement

Ensure that the bell icon and tray icon for notifications are displayed on desktop when using the MinervaNeue skin on Wikipedia.

BDD

Feature: Notification Icons on Desktop in MinervaNeue Skin

Scenario: Ensure bell and tray icons are visible on desktop in MinervaNeue skin

Given the user is logged in
And the user is viewing a page on desktop using the MinervaNeue skin
When the page loads
Then the bell icon and tray icon for notifications should be visible in the header
Test Steps

Test Case 1: Ensure Bell and Tray Icons Are Visible on Desktop Using MinervaNeue Skin

  1. Log in to Wikipedia on desktop.
  2. Navigate to any page using the Minerva skin (e.g., https://en.wikipedia.org/wiki/Olmec_colossal_heads?useskin=minerva).
  3. ✅❓❌⬜ AC1: Confirm that the bell icon and the tray icon for notifications are visible in the header.

QA Results - Beta

ACStatusDetails
1✅T376491#10215486

QA Results - Prod

ACStatusDetails
1✅T376491#10227460

Details

SubjectRepoBranchLines +/-
Strengthen CSS selectors for Minerva Echo iconsmediawiki/skins/MinervaNeuemaster+3 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdrewniak created this task.Oct 4 2024, 5:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 4 2024, 5:03 PM
Jdlrobson added a project: MinervaNeue (Desktop).Oct 4 2024, 5:12 PM
Jdlrobson subscribed.Oct 5 2024, 12:30 AM

The easiest solution here: Rule in skinStyles/ext.echo.styles.badge.less
should be made more specific e.g. .minerva-icon.minerva-icon--bell.

.minerva-icon.minerva-icon--bell {
	.cdx-mixin-css-icon( @cdx-icon-bell, @color-subtle);
}

.minerva-icon.minerva-icon--tray {
	.cdx-mixin-css-icon( @cdx-icon-tray, @color-subtle);
}
Jdlrobson triaged this task as Low priority.Oct 5 2024, 12:30 AM
Jdlrobson added a project: Web Team Essential Work 2024 (Adoption of Codex for icons and links).
gerritbot added a comment.Oct 7 2024, 6:16 PM

Change #1078462 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Strengthen CSS selectors for Minerva Echo icons

https://gerrit.wikimedia.org/r/1078462

gerritbot added a project: Patch-For-Review.Oct 7 2024, 6:16 PM
Jdlrobson renamed this task from Minerva on desktop missing notification icons to [Regression] Minerva on desktop missing notification icons.Oct 7 2024, 11:52 PM
Jdlrobson assigned this task to Edtadros.
Jdlrobson edited projects, added Web-Team-Backlog (FY2024-25 Q2 Sprint 1); removed Web-Team-Backlog.
Jdlrobson moved this task from Needs analysis to QA on the Web-Team-Backlog (FY2024-25 Q2 Sprint 1) board.
Jdlrobson added a project: Regression.
Jdlrobson added a parent task: T374145: Migrate ResourceLoader Icons in Minerva to use Codex.
gerritbot added a comment.Oct 7 2024, 11:55 PM

Change #1078462 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Strengthen CSS selectors for Minerva Echo icons

https://gerrit.wikimedia.org/r/1078462

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.26; 2024-10-08).Oct 8 2024, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 8 2024, 12:30 AM
Edtadros reassigned this task from Edtadros to GMikesell-WMF.Oct 8 2024, 9:29 PM
Edtadros subscribed.
GMikesell-WMF updated the task description. (Show Details)Oct 9 2024, 6:42 PM
GMikesell-WMF added a comment.Oct 9 2024, 7:19 PM

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma 15.0
Browser: Chrome 129
Device: MBA
Emulated Device: NA

Test Artifact(s):

https://en.wikipedia.beta.wmflabs.org/wiki/Batman?useskin=minerva

Test Steps

Test Case 1: Ensure Bell and Tray Icons Are Visible on Desktop Using MinervaNeue Skin

  1. Log in to Wikipedia on desktop.
  2. Navigate to any page using the Minerva skin (e.g.,Beta- https://en.wikipedia.beta.wmflabs.org/wiki/Batman?useskin=minerva; PROD- https://en.wikipedia.org/wiki/Olmec_colossal_heads?useskin=minerva).
  3. ✅ AC1: Confirm that the bell icon and the tray icon for notifications are visible in the header.

2024-10-09_11-40-22.png (747×1 px, 225 KB)

GMikesell-WMF removed GMikesell-WMF as the assignee of this task.Oct 9 2024, 7:20 PM
GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF moved this task from QA to Ready for Signoff on the Web-Team-Backlog (FY2024-25 Q2 Sprint 1) board.
GMikesell-WMF subscribed.
Jdlrobson assigned this task to ovasileva.Oct 10 2024, 4:45 PM
Edtadros mentioned this in T375670: Verify 1.43.0-wmf.26 deployment.Oct 13 2024, 2:02 AM
ovasileva closed this task as Resolved.Oct 14 2024, 10:20 PM
Edtadros added a project: Verified.Oct 15 2024, 1:46 AM

Test Result - Prod

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma 15.0
Browser: Chrome 129
Device: MBA
Emulated Device: NA

Test Artifact(s):

https://en.wikipedia.beta.wmflabs.org/wiki/Batman?useskin=minerva

Test Steps

Test Case 1: Ensure Bell and Tray Icons Are Visible on Desktop Using MinervaNeue Skin

  1. Log in to Wikipedia on desktop.
  2. Navigate to any page using the Minerva skin (e.g.,Beta- https://en.wikipedia.beta.wmflabs.org/wiki/Batman?useskin=minerva; PROD- https://en.wikipedia.org/wiki/Olmec_colossal_heads?useskin=minerva).
  3. ✅ AC1: Confirm that the bell icon and the tray icon for notifications are visible in the header.

screenshot 94.png (1×1 px, 624 KB)

Edtadros updated the task description. (Show Details)Oct 15 2024, 1:48 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits