Update GlobalBlockingHooks for global autoblocks
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

The GlobalBlockingHooks file contains several pieces of code that need to be updated for global autoblocks. This includes not displaying global autoblocks on Special:Contributions for the IP address that is targeted by the autoblock and adding a block notice that is specific to global autoblocks.

Acceptance criteria

Special:Contributions does not display a block banner if the IP is only globally autoblocked
Special:Block does not have a "other blocks" link if the IP is only globally autoblocked
The block notice displayed when a user is prevented from performing actions is updated to display a custom notice for global autoblocks
- This message is correctly overridden for WMF wikis, so that users are pointed to the correct place

Details

Related Changes in Gerrit:

Subject	Author	Repo	Branch	Lines +/-
Add WMF overrides for global autoblock blocked text messages	Dreamy Jazz	mediawiki/extensions/WikimediaMessages	master	+12 -0
[GlobalBlocking] Ignore wikimedia-globalblocking-blockedtext-autoblock*	Dreamy Jazz	translatewiki	master	+1 -0
Add new GlobalBlocking blocked text message keys	Dreamy Jazz	mediawiki/extensions/WikimediaEvents	master	+4 -0
[GlobalBlocking] Mark globalblocking-blockedtext-* as ignored	Dreamy Jazz	translatewiki	master	+3 -2
Update GlobalBlockingHooks for global autoblocks	Dreamy Jazz	mediawiki/extensions/GlobalBlocking	master	+59 -9

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
		Restricted Task
Resolved	kostajh	T294511 2021 Security Team wikireplicas audit
Declined	None	T284948 Raw IPs of logged-out users disclosed in wiki-replicas
Resolved	• Niharika	T324492 Temporary accounts - MVP
Resolved	Madalina	T326816 [Epic] Update features for temporary accounts
Resolved	Dreamy_Jazz	T355286 [Epic] Globally blocking a temporary account should prevent further account creations
Resolved	Dreamy_Jazz	T368949 [Epic] Implement global autoblocks from global user blocks
Resolved	Dreamy_Jazz	T377230 Update GlobalBlocking interfaces to properly handle global autoblocks
Resolved	Dreamy_Jazz	T377328 Update GlobalBlockingHooks for global autoblocks

Event Timeline

Dreamy_Jazz created this task.Oct 16 2024, 1:31 PM

Change #1080768 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Update GlobalBlockingHooks for global autoblocks

https://gerrit.wikimedia.org/r/1080768

gerritbot added a project: Patch-For-Review.Oct 16 2024, 5:27 PM

Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)) board.Oct 16 2024, 5:46 PM

Change #1080768 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Update GlobalBlockingHooks for global autoblocks

https://gerrit.wikimedia.org/r/1080768

Change #1080776 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/WikimediaEvents@master] Add new GlobalBlocking blocked text message keys

https://gerrit.wikimedia.org/r/1080776

Change #1080782 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[translatewiki@master] Mark globalblocking-blockedtext-* messages as ignored

https://gerrit.wikimedia.org/r/1080782

Change #1080782 merged by jenkins-bot:

[translatewiki@master] [GlobalBlocking] Mark globalblocking-blockedtext-* as ignored

https://gerrit.wikimedia.org/r/1080782

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.28; 2024-10-22).Oct 16 2024, 7:00 PM

Change #1080796 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/WikimediaMessages@master] Add WMF overrides for global autoblock blocked text messages

https://gerrit.wikimedia.org/r/1080796

Change #1080776 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Add new GlobalBlocking blocked text message keys

https://gerrit.wikimedia.org/r/1080776

Change #1080798 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[translatewiki@master] [GlobalBlocking] Ignore wikimedia-globalblocking-blockedtext-autoblock*

https://gerrit.wikimedia.org/r/1080798

Dreamy_Jazz updated the task description. (Show Details)Oct 16 2024, 7:28 PM

Change #1080798 merged by jenkins-bot:

[translatewiki@master] [GlobalBlocking] Ignore wikimedia-globalblocking-blockedtext-autoblock*

https://gerrit.wikimedia.org/r/1080798

Change #1080796 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] Add WMF overrides for global autoblock blocked text messages

https://gerrit.wikimedia.org/r/1080796

Dreamy_Jazz moved this task from Needs review to Needs QA on the Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)) board.Oct 16 2024, 8:23 PM

Dreamy_Jazz set the point value for this task to 2.

Maintenance_bot removed a project: Patch-For-Review.Oct 16 2024, 8:30 PM

For QA I would suggest checking that the acceptance criteria have been met.

To be able to complete this test you will need to set $wgGlobalBlockingEnableAutoblocks = true; in your LocalSettings.php. If you wish to test this in patch demo, I can make a patch which you can include in the creation of the wiki to be able to test on patch demo (just let me know).

Dreamy_Jazz moved this task from Backlog to In progress on the Temporary accounts (Blockers to minor pilot wiki deployment) board.Oct 17 2024, 4:20 PM

QA has been completed and the new code is functioning per the Acceptance Criteria.

Dreamy_Jazz closed this task as Resolved.Oct 25 2024, 10:58 AM

Update GlobalBlockingHooks for global autoblocksClosed, ResolvedPublic2 Estimated Story PointsActions