Description

Sometimes after clicking Publish in the Publish your changes dialog, the Leave site? dialog comes up, inappropriately, and can easily cause confusion. Even though the function has just been saved, the Leave site? dialog may give the impression that something went wrong. (In fact, that dialogue says "changes you made may not be saved".) It is tempting to then click Cancel and make another attempt to save the function, which can lead to additional confusion. (A message comes up indicating a conflict with an existing label. In that case, the user might then be tempted to change their label and try again, which can lead to the creation of a 2nd, redundant function.)

I've been able to reproduce this both on production and also in my local environment, as follows, using Google chrome browser.

Steps to reproduce:

1. Go to Special pages
2. Select Create a new object
3. Enter a label and description in the About section
4. Then, in Contents, select function as the object type
5. Finish specifying the function
6. Click Publish
7. Enter description of work done in the Publish your changes dialog
8. Click Publish

Observed behavior:

1. Then the Leave site? dialog appears, as shown in the attached image, with the Publish your changes dialog still showing
2. At this point, one can confirm that the new function has been saved
3. But the Leave site? dialog causes confusion and can tempt the user into taking unnecessary and inconvenient next steps.

Expected behavior (Acceptance criteria):

• The Leave site? should not appear, and the publication should succeed normally with the Publish your changes dialog going away

Devices and Design (URLs or screenshots, if applicable):

• Desktop: ...
• Small screens/mobile: ...

Completion checklist

• Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Front-end_Task/Bug_Completion_Checklist