Page MenuHomePhabricator

[regression] Wikipedia Article Recommender extension broken in Chrome 130
Closed, ResolvedPublic

Description

Background

The current version of the experimental Web team chrome browser extension, (1.0.4) is broken in Chrome v130 (released October 15th) due to an issue with the CRX-JS framework that it's built on.

The extension is currently running the sidebar suggestions experiment on production Wikipedia.

Expected

Screenshot 2024-10-18 at 1.27.50 PM.png (1×2 px, 1 MB)

Actual

Screenshot 2024-10-18 at 1.28.05 PM.png (1×2 px, 968 KB)

Test Steps

  • For QA engineer to fill out

Acceptance criteria

This task was created by Version 1.2.0 of the Web team task template using phabulous

Derived Requirement

Ensure that the Wikipedia Article Recommender extension, version 1.0.5, works properly in Chrome v130 or higher, rendering the sidebar suggestions experiment correctly without errors, addressing the regression from version 1.0.4.

BDD

gherkin
Feature: Wikipedia Article Recommender Extension Functionality in Chrome v130

Scenario: Ensure the sidebar suggestions experiment renders correctly in Chrome v130
  Given the user has installed version 1.0.5 of the Wikipedia Article Recommender extension
  And the user is using Chrome v130 or higher
  When the user visits a production Wikipedia article page
  Then the sidebar suggestions experiment should render correctly

Test Result - Beta|Prod

Status: ✅ PASS / ❓Need More Info / ❌ FAIL
Environment: beta/xyzwiki
OS: macOS Sonoma 15.0
Browser: Chrome 130
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure Sidebar Suggestions Experiment Renders in Chrome v130

  1. Using Chrome v130 or higher, install the Wikipedia Article Recommender extension version 1.0.5.
  2. Navigate to any production Wikipedia article page.
  3. ✅❓❌⬜ AC1: Confirm that the sidebar suggestions experiment is rendered correctly without errors.

QA Results - PROD

ACStatusDetails
1T377610#10260525

Event Timeline

@Jdrewniak The sidebar suggestion does not appear with the Wikipedia Article Recommender extension, version 1.0.5, Chrome v130 as seen in the gif below. Am I doing something wrong?

Test Result - Prod

Status: ❌ FAIL
Environment: PROD
OS: macOS Sonoma 15.0
Browser: Chrome 130
Device: MBA
Emulated Device: NA

Test Artifact(s):

https://en.wikipedia.org/wiki/Galileo_project

Test Steps

Test Case 1: Ensure Sidebar Suggestions Experiment Renders in Chrome v130

  1. Using Chrome v130 or higher, install the Wikipedia Article Recommender extension version 1.0.5.
  2. Navigate to any production Wikipedia article page.
  3. AC1: Confirm that the sidebar suggestions experiment is rendered correctly without errors.

2024-10-21_15-15-34.mp4.gif (1×1 px, 1 MB)

@GMikesell-WMF thanks for double checking. I'm not sure if it was the fix that wasn't working or the build output, but I've uploaded a patch chain that aims to fix these issues (and this time I'll wait for QA before publishing :) )

The QA process pre-publishing is a little different:

  • Uninstall the existing Wikipedia Article Recommender extension
  • Open the chrome://extensions page with developer mode enabled
  • Install the build by dragging the attached zip onto that page
  • Verify functionality

@GMikesell-WMF thanks for double checking. I'm not sure if it was the fix that wasn't working or the build output, but I've uploaded a patch chain that aims to fix these issues (and this time I'll wait for QA before publishing :) )

The QA process pre-publishing is a little different:

  • Uninstall the existing Wikipedia Article Recommender extension
  • Open the chrome://extensions page with developer mode enabled
  • Install the build by dragging the attached zip onto that page
  • Verify functionality

@Jdrewniak Looks like we are good to go as seen in the screenshot. You can publish it. Just let me know when it's up so I can retest it again, thanks!

2024-10-22_07-55-27.png (994×2 px, 516 KB)

Test Result - Prod

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 15.0
Browser: Chrome 130
Device: MBA
Emulated Device: NA

Test Artifact(s):

https://en.wikipedia.org/wiki/Galileo_project

Test Steps

Test Case 1: Ensure Sidebar Suggestions Experiment Renders in Chrome v130

  1. Using Chrome v130 or higher, install the Wikipedia Article Recommender extension version 1.0.5.
  2. Navigate to any production Wikipedia article page.
  3. AC1: Confirm that the sidebar suggestions experiment is rendered correctly without errors.

2024-10-24_12-30-41.mp4.gif (510×1 px, 862 KB)

ovasileva claimed this task.

Looks good, thanks @GMikesell-WMF!