Page MenuHomePhabricator

PHP Deprecated: Use of MediaWiki\Output\OutputPage::setIndexPolicy with index after noindex was deprecated in MediaWiki 1.43. [Called from MediaWiki\Extension\FundraiserLandingPage\Specials\FundraiserLandingPage::execute]
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Use of MediaWiki\Output\OutputPage::setIndexPolicy with index after noindex was deprecated in MediaWiki 1.43. [Called from MediaWiki\Extension\FundraiserLandingPage\Specials\FundraiserLandingPage::execute]
FrameLocationCall
from/srv/mediawiki/php-1.43.0-wmf.28/extensions/FundraiserLandingPage/includes/Specials/FundraiserLandingPage.php(52)
#0[internal function]MWExceptionHandler::handleError(int, string, string, string, array)
#1/srv/mediawiki/php-1.43.0-wmf.28/includes/debug/MWDebug.php(385)trigger_error(string, int)
#2/srv/mediawiki/php-1.43.0-wmf.28/includes/debug/MWDebug.php(356)MediaWiki\Debug\MWDebug::sendRawDeprecated(string, bool, string)
#3/srv/mediawiki/php-1.43.0-wmf.28/includes/debug/MWDebug.php(237)MediaWiki\Debug\MWDebug::deprecatedMsg(string, string, string, int)
#4/srv/mediawiki/php-1.43.0-wmf.28/includes/GlobalFunctions.php(771)MediaWiki\Debug\MWDebug::deprecated(string, string, string, int)
#5/srv/mediawiki/php-1.43.0-wmf.28/includes/Output/OutputPage.php(1094)wfDeprecated(string, string)
#6/srv/mediawiki/php-1.43.0-wmf.28/extensions/FundraiserLandingPage/includes/Specials/FundraiserLandingPage.php(52)MediaWiki\Output\OutputPage->setIndexPolicy(string)
#7/srv/mediawiki/php-1.43.0-wmf.28/includes/specialpage/SpecialPage.php(728)MediaWiki\Extension\FundraiserLandingPage\Specials\FundraiserLandingPage->execute(null)
#8/srv/mediawiki/php-1.43.0-wmf.28/includes/specialpage/SpecialPageFactory.php(1726)MediaWiki\SpecialPage\SpecialPage->run(null)
#9/srv/mediawiki/php-1.43.0-wmf.28/includes/actions/ActionEntryPoint.php(504)MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, MediaWiki\Context\RequestContext)
#10/srv/mediawiki/php-1.43.0-wmf.28/includes/actions/ActionEntryPoint.php(146)MediaWiki\Actions\ActionEntryPoint->performRequest()
#11/srv/mediawiki/php-1.43.0-wmf.28/includes/MediaWikiEntryPoint.php(200)MediaWiki\Actions\ActionEntryPoint->execute()
#12/srv/mediawiki/php-1.43.0-wmf.28/index.php(58)MediaWiki\MediaWikiEntryPoint->run()
#13/srv/mediawiki/w/index.php(3)require(string)
#14{main}
Impact

New warnings being logged at a rate of ~115/minute starting with the rollout of .28 to group1.

Details

Request URL
https://donate.wikimedia.org/w/index.php?1=*&appeal=*&contact_hash=*&contact_id=*&country=*&hpc=*&link_id=*&monthlypitch=*&title=*&uselang=*&wmf_campaign=*&wmf_medium=*&wmf_source=*

Event Timeline

dancy triaged this task as Unbreak Now! priority.Oct 24 2024, 4:08 PM
dancy created this task.

I made this a train blocker because I'm worried about the warning log rate when rolling to group2.

I don't think it will get any worse - FundraiserLandingPage only runs on DonateWiki which is group1.

I don't think it will get any worse - FundraiserLandingPage only runs on DonateWiki which is group1.

Ah, thanks for that information. I will remove this as a blocker, however I will leave the priority at unbreak now because this is the top error in logs.

Change #1082825 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/extensions/FundraiserLandingPage@master] Use SpecialPage::getRobotPolicy to set robot policy

https://gerrit.wikimedia.org/r/1082825

Change #1082825 merged by jenkins-bot:

[mediawiki/extensions/FundraiserLandingPage@master] Use SpecialPage::getRobotPolicy to set robot policy

https://gerrit.wikimedia.org/r/1082825

Ammarpad claimed this task.

Change #1082835 had a related patch set uploaded (by Ahmon Dancy; author: Ammarpad):

[mediawiki/extensions/FundraiserLandingPage@wmf/1.43.0-wmf.28] Use SpecialPage::getRobotPolicy to set robot policy

https://gerrit.wikimedia.org/r/1082835

Change #1082835 merged by jenkins-bot:

[mediawiki/extensions/FundraiserLandingPage@wmf/1.43.0-wmf.28] Use SpecialPage::getRobotPolicy to set robot policy

https://gerrit.wikimedia.org/r/1082835

Mentioned in SAL (#wikimedia-operations) [2024-10-24T19:26:57Z] <dancy@deploy2002> Started scap sync-world: Backport for [[gerrit:1082835|Use SpecialPage::getRobotPolicy to set robot policy (T378108)]]

Mentioned in SAL (#wikimedia-operations) [2024-10-24T19:29:17Z] <dancy@deploy2002> dancy: Backport for [[gerrit:1082835|Use SpecialPage::getRobotPolicy to set robot policy (T378108)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-10-24T19:34:05Z] <dancy@deploy2002> Finished scap sync-world: Backport for [[gerrit:1082835|Use SpecialPage::getRobotPolicy to set robot policy (T378108)]] (duration: 07m 08s)

Blunt2531 lowered the priority of this task from Unbreak Now! to Low.Oct 25 2024, 3:37 AM
Blunt2531 added a subscriber: MusikAnimal.
Blunt2531 subscribed.
JJMC89 closed this task as Resolved.
JJMC89 raised the priority of this task from Low to Unbreak Now!.