re-enable a routinely flakey JS integration test
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ecarg
	Nov 7 2024, 10:59 PM

Description

What/Why:
When running javascript-all-test.js, the particular test 'javascript - debug' keep causing timeouts. This was recently spotted during the service-utils migration, however has been known to occur before. We tried to move around the after() block and also using global hooks to no avail. Because this debugging was blocking for too long than it was worth, we disabled it with hopes to address later during a Fix-it week.

How:

Find out why this is flakey OR find out how to prevent the after() block doesn't get stuck (see parent task)
Re-enable test OR refactor it

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	wikifunctions: Upgrade evaluators from 2025-01-08-143723 to 2025-01-22-212306	operations/deployment-charts	master	+2 -2

Customize query in gerrit

Related Changes in GitLab:

	Title	Reference	Author	Source Branch	Dest Branch
	tests: Re-enable previously flaky 'javascript - debug' test	repos/abstract-wiki/wikifunctions/function-evaluator!292	apine	apine-reenable-debug	main

Customize query in GitLab

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Declined		None	T378763 Mocha "after" block doesn't run if a test times out
		Resolved		cmassaro	T379331 re-enable a routinely flakey JS integration test

Event Timeline

Noting that if we want to try global hooks again, we need to use .mocharc.js as .mocha.opts has been deprecated since V6+ https://github.com/mochajs/mocha/blob/main/example/config/.mocharc.js

Jdforrester-WMF triaged this task as Medium priority.Nov 13 2024, 5:33 PM

Jdforrester-WMF moved this task from To Triage to Engineering Backlog on the Abstract Wikipedia team board.

apine updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/292

Reenable previously flaky test.

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/292

tests: Re-enable previously flaky 'javascript - debug' test

Change #1113572 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2025-01-08-143723 to 2025-01-22-212306

https://gerrit.wikimedia.org/r/1113572

gerritbot added a project: Patch-For-Review.Jan 22 2025, 9:54 PM

Change #1113572 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2025-01-08-143723 to 2025-01-22-212306