Description

Body text and buttons should use normal UI 14px font size. Currently the whole dialog uses 18px, but probably only the header should use the larger size:

Observed	Expected

Details

	Subject	Repo	Branch	Lines +/-
	EmailAlertDialog: Remove font size and line height overrides	mediawiki/extensions/ReportIncident	master	+0 -9

Customize query in gerrit

Related Objects

Mentioned In: rEREIf1bf9e8b06a0: EmailAlertDialog: Remove font size and line height overrides
Mentioned Here: rEREI404454b38e8c: form: Show dialog to visit Special:ChangeEmail

Event Timeline

Esanders created this task.Nov 26 2024, 12:26 PM

Restricted Application added a project: Trust and Safety Product Team. · View Herald TranscriptNov 26 2024, 12:26 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

This was done deliberately in rEREI404454b38e8c: form: Show dialog to visit Special:ChangeEmail but I also agree that there is no need to use the large size overrides here:

.ext-reportincident-emaildialog {
	font-size: @font-size-large;
	line-height: @line-height-medium;
}

@KColeman-WMF would it be OK to remove these overrides?

Change #1098017 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/ReportIncident@master] EmailAlertDialog: Remove font size and line height overrides

https://gerrit.wikimedia.org/r/1098017

gerritbot added a project: Patch-For-Review.Nov 26 2024, 12:40 PM

In T380860#10357273, @kostajh wrote:
This was done deliberately in rEREI404454b38e8c: form: Show dialog to visit Special:ChangeEmail but I also agree that there is no need to use the large size overrides here:
.ext-reportincident-emaildialog {
	font-size: @font-size-large;
	line-height: @line-height-medium;
}
@KColeman-WMF would it be OK to remove these overrides?