Page MenuHomePhabricator
Create Task
Maniphest T381124

Unified Dashboard: Suggestions for "All collections" filter are fetched, even when a single collection filter is selected
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  1. Visit the Unified Dashboard.
  2. Open the filters dialog, select a single collection filter, and click on "Done" button to apply it.

What happens?:
Suggestions for "All collections" are fetched from the Recommendation API.

What should have happened instead?:
The seed URL parameter should be filled with the selected collection name inside the request URL to the Recommendation API, and suggestions only for that specific collections should be fetched.

Screencast:

Derived Requirement

Ensure that when a single collection filter is selected in the Unified Dashboard, the seed URL parameter in the Recommendation API request is populated with the selected collection name, and suggestions are fetched only for that specific collection.

Test Steps

Test Case 1: Ensure Selected Collection Filter is Applied to the Recommendation API Request

  1. Visit the Unified Dashboard.
  2. Open the filters dialog and select a single collection filter.
  3. Click the "Done" button to apply the selected filter.
  4. ✅❓❌⬜ AC1: Verify that the request URL to the Recommendation API contains the seed parameter populated with the selected collection name.

QA Results - Test Mobile ContentTranslation

ACStatusDetails
1✅T381124#10405053

Details

SubjectRepoBranchLines +/-
CX3 Build 0.2.0+20241202mediawiki/extensions/ContentTranslationmaster+4 K -4 K
Fetch suggestions specific to a single collection when selected as filtermediawiki/extensions/ContentTranslationmaster+35 -32
Customize query in gerrit

Event Timeline

ngkountas created this task.Thu, Nov 28, 9:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptThu, Nov 28, 9:04 PM
ngkountas claimed this task.Thu, Nov 28, 9:04 PM
ngkountas triaged this task as High priority.
ngkountas moved this task from Prioritized to In-progress on the LPL Hypothesis board.
gerritbot added a comment.Thu, Nov 28, 9:17 PM

Change #1099044 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] Fetch suggestions specific to a single collection when selected as filter

https://gerrit.wikimedia.org/r/1099044

gerritbot added a project: Patch-For-Review.Thu, Nov 28, 9:17 PM
ngkountas moved this task from In-progress to Needs Code Review on the LPL Hypothesis board.Thu, Nov 28, 9:18 PM
• Sandraklemma closed this task as a duplicate of T370998: Wikiwho API failing to find an extant revision.Thu, Nov 28, 10:44 PM
JJMC89 reopened this task as Open.Thu, Nov 28, 10:47 PM
SBisson moved this task from Needs Code Review to Pending deployment on the LPL Hypothesis board.Fri, Nov 29, 2:22 PM
gerritbot added a comment.Fri, Nov 29, 3:36 PM

Change #1099044 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Fetch suggestions specific to a single collection when selected as filter

https://gerrit.wikimedia.org/r/1099044

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.6; 2024-12-03).Fri, Nov 29, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Fri, Nov 29, 4:30 PM
gerritbot added a comment.Mon, Dec 2, 5:56 PM

Change #1099753 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20241202

https://gerrit.wikimedia.org/r/1099753

gerritbot added a project: Patch-For-Review.Mon, Dec 2, 5:56 PM
gerritbot added a comment.Mon, Dec 2, 7:45 PM

Change #1099753 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20241202

https://gerrit.wikimedia.org/r/1099753

Maintenance_bot removed a project: Patch-For-Review.Mon, Dec 2, 8:37 PM
SBisson moved this task from Pending deployment to Needs QA on the LPL Hypothesis board.Fri, Dec 6, 3:58 PM
GMikesell-WMF updated the task description. (Show Details)Mon, Dec 16, 3:06 AM
GMikesell-WMF updated Other Assignee, added: GMikesell-WMF.
GMikesell-WMF subscribed.
GMikesell-WMF added a comment.Mon, Dec 16, 4:37 AM

@ngkountas The seed URL parameter should be filled with the selected collection name inside the request URL to the Recommendation API, and suggestions only for that specific collections should be fetched as seen in the gif. I will move this to Done. Thanks for all your work!

Test Result - Test Wikipedia Translate

Status: ✅ PASS
Environment: Test Wikipedia Translate
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device: NA

Test Artifact(s):

https://test.m.wikipedia.org/w/index.php?title=Special:ContentTranslation&active-list=suggestions&from=en&to=el&filter-type=collections&filter-id=Women%27s%20Health

Test Steps

Test Case 1: Ensure Selected Collection Filter is Applied to the Recommendation API Request

  1. Visit the Unified Dashboard.
  2. Open the filters dialog and select a single collection filter.
  3. Click the "Done" button to apply the selected filter.
  4. ✅ AC1: Verify that the request URL to the Recommendation API contains the seed parameter populated with the selected collection name.

2024-12-15_19-01-10.mp4.gif (992×1 px, 3 MB)

GMikesell-WMF updated the task description. (Show Details)Mon, Dec 16, 4:38 AM
GMikesell-WMF updated Other Assignee, removed: GMikesell-WMF.
GMikesell-WMF moved this task from Needs QA to Design Signoff on the LPL Hypothesis board.
Pginer-WMF moved this task from Design Signoff to Product Signoff on the LPL Hypothesis board.Thu, Dec 19, 2:14 PM
PWaigi-WMF closed this task as Resolved.Fri, Dec 20, 8:09 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits