Page MenuHomePhabricator
Create Task
Maniphest T381215

cdx-message has border without margins
Open, Needs TriagePublicBUG REPORT
Actions

Description

Codex "cdx-message" class has border but without any top and bottom margins. this cause sometimes to overlap with next bordered objects like attached picture

image.png (262×1 px, 53 KB)

Event Timeline

hubaishan created this task.Sun, Dec 1, 8:27 AM
Restricted Application added a project: Design-System-Team. · View Herald TranscriptSun, Dec 1, 8:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Gerges subscribed.Mon, Dec 2, 9:47 AM
CCiufo-WMF moved this task from Inbox to Triaging on the Design-System-Team board.Tue, Dec 10, 4:36 PM
CCiufo-WMF added subscribers: DTorsani-WMF, bmartinezcalvo, CCiufo-WMF.

I believe this is by design -- we don't know every way messages could be used, so we leave it up to the user to add margins (or padding) when applicable. cc: @bmartinezcalvo @DTorsani-WMF

bmartinezcalvo added a comment.EditedTue, Dec 10, 4:57 PM
El T381215#10394287, @CCiufo-WMF escribió:

I believe this is by design -- we don't know every way messages could be used, so we leave it up to the user to add margins (or padding) when applicable. cc: @bmartinezcalvo @DTorsani-WMF

Yes, since we don't know where this Message could be included, the separation between the Message and the surrounding elements can be customized by using our spacing tokens. This means the padding is not part of the Message component itself but is handled as a separate element.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits