Page MenuHomePhabricator

Remove code duplication relating to type inference
Closed, ResolvedPublic2 Estimated Story Points

Description

Background

In both the server and client, we infer types about the x axis and y axis so we can format them correctly. We propose doing this on the server and passing this information to the client via data-x-axis and data-y-axis attributes. By January caching should not be a problem provided T382039 has been completed.

User story

As a user I want consistent rendering of axis on web and apps which do not run JS (e.g. mobile apps)

Requirements

BDD

  • For QA engineer to fill out

Test Steps

  • For QA engineer to fill out

Design

  • Add mockups and design requirements

Acceptance criteria

  • Add acceptance criteria

Communication criteria - does this need an announcement or discussion?

  • Add communication criteria

Rollback plan

  • What is the rollback plan in production for this task if something goes wrong?

This task was created by Version 1.3.0 of the Web team task template using phabulous

Event Timeline

Jdlrobson triaged this task as Medium priority.Thu, Dec 12, 12:58 AM
Jdlrobson moved this task from Backlog to Up Next on the Charts board.
Jdlrobson updated the task description. (Show Details)

Change #1099833 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Chart@master] Move logic for type infering to server

https://gerrit.wikimedia.org/r/1099833

Change #1099833 merged by jenkins-bot:

[mediawiki/extensions/Chart@master] Move logic for type infering to server

https://gerrit.wikimedia.org/r/1099833

Change #1108130 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Chart@wmf/1.44.0-wmf.8] Move logic for type infering to server

https://gerrit.wikimedia.org/r/1108130

Change #1108130 merged by jenkins-bot:

[mediawiki/extensions/Chart@wmf/1.44.0-wmf.8] Move logic for type infering to server

https://gerrit.wikimedia.org/r/1108130

Mentioned in SAL (#wikimedia-operations) [2025-01-06T21:12:10Z] <cjming@deploy2002> Started scap sync-world: Backport for [[gerrit:1108130|Move logic for type infering to server (T382042)]]

Mentioned in SAL (#wikimedia-operations) [2025-01-06T21:16:51Z] <cjming@deploy2002> cjming, jdlrobson: Backport for [[gerrit:1108130|Move logic for type infering to server (T382042)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2025-01-06T21:31:41Z] <cjming@deploy2002> Finished scap sync-world: Backport for [[gerrit:1108130|Move logic for type infering to server (T382042)]] (duration: 19m 31s)

Jdlrobson moved this task from Code Review to Ready for Signoff on the Charts (Sprint 13) board.
Jdlrobson updated the task description. (Show Details)
Jdlrobson set the point value for this task to 2.