Page MenuHomePhabricator

Certain monuments don't have names in the monuments database
Closed, DeclinedPublic

Description

In Netherlands there are various monuments without names that appear in the list.

The api should not return these or the data should be given names.

The client should not have to deal with these problematic monuments.


Version: unspecified
Severity: normal

Details

Reference
bz38695

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:02 AM
bzimport set Reference to bz38695.
bzimport added a subscriber: Unknown Object (MLST).

mysql> SELECT COUNT(*) FROM monuments_all WHERE country='nl' AND lang='nl' AND name='' ;
+----------+

COUNT(*)

+----------+

2250

+----------+

Judging from the entries these are new additions. Not sure why the descriptions are not filled. This is something that should be fixed at the Dutch Wikipedia.

From a quick search through the monument database, there appear to be ~165k monuments with no name:

mysql> select count(*) from monuments_all where name='';
+----------+

count(*)

+----------+

164796

+----------+

This affects 18 different countries:

mysql> select distinct country from monuments_all where name='';
+------------+

country

+------------+

at
be-bru
be-wal
de-by
de-he
de-nrw
de-nrw-bm
es
in
lu
mt
mx
nl
no
ro
se-fornmin
sk
ua

+------------+

All but one of those monuments has data in the 'field':
mysql> select count(*) from monuments_all where name='' and source='';
+----------+

count(*)

+----------+

1

+----------+

If it's too difficult to otherwise determine a name for the monument, perhaps the data could be updated to construct a name based off of the 'title' field in the source, perhaps with an incremented digit appended to it. For instance:
http://de.wikipedia.org/w/index.php?title=Liste_der_denkmalgeschützten_Objekte_in_Sedliská&redirect=no&useskin=monobook&oldid=105722097
could become:
Liste der denkmalgeschützten Objekte in Sedliská - 01

Or something like that. Rather than hack something into the android app for this, I recommend that this happen in the database itself. That way everyone using the app, including older versions of the app, would be able to see the updated monuments.

Sounds good to me. Lets do this. This is not a problem with the app but the data. We should be striving to improve our data.

A name based on the order in the wikipedia page would be useless. I'd either base it on the id («Unnamed monument with id XYZ») or simply remove them altogether from the app, since you can't photograph a monument you can't locate.

See my longer post at the mailing list: http://lists.wikimedia.org/pipermail/wikilovesmonuments/2012-September/004348.html

Sounds like a good idea. I think this update should be done on the database to ensure users running an older version of the app pick up this change.

JeanFred added a subscriber: JeanFred.

Lots of monuments do not have name, and we can’t invent them (well we could but well :). I don’t believe we should filter them out in the API. What would be possible would be an API parameter to filter them out, but we do not have resources for this, and it seems the use case (the app) is not active anymore.

I’ll decline this, feel free to reopen. :)