Page MenuHomePhabricator

VisualEditor: Round-tripping of double apostrophes causes them to be interpreted as wikitext
Closed, ResolvedPublic

Description

Repro:

  1. Go to http://www.mediawiki.org/w/index.php?title=VisualEditor:Sandbox&action=edit&oldid=569294 , save, then edit it with VE
  2. Insert '' in the word "link", save. diff: http://www.mediawiki.org/w/index.php?title=VisualEditor:Sandbox&diff=569295&oldid=569294
  3. Edit it with VE again, select "li''nk", and make it italic, save. diff: http://www.mediawiki.org/w/index.php?title=VisualEditor:Sandbox&diff=next&oldid=569295
  4. So many unexpected quotes

Version: unspecified
Severity: critical

Details

Reference
bz39058

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:58 AM
bzimport set Reference to bz39058.

This is fixed in production in that it doesn't introduce the excess quotes any more, see https://www.mediawiki.org/w/index.php?title=VisualEditor%3ABug39058&diff=571888&oldid=571887 . It still adds <span> tags though, but that's fixed on master.

On my localhost, the diff I get is as follows, and I think that's perfectly reasonable:

− '''This is a te<nowiki>''</nowiki>st page for bug 35058.'''
+ '''This is a ''te<nowiki>''</nowiki>st'' page for bug 35058.'''