Page MenuHomePhabricator

[Regression] ResourceLoader should not serve parsed {{PLURAL:}} tags but leave raw
Closed, ResolvedPublic

Description

In UploadWizard, we have a bunch of messages used in the UI to indicate what's going on with the file or the files. We've been using {{PLURAL}} properly, and that was great.

However, there appears to be a bug with core now. I'm only getting the plural version, never the singular one.

I have been unable to pinpoint the source of the error, since apparently the localisation cache helps to befuddle git-bisect. However, I've been generally convinced that it's a core bug because of the constant state of UploadWizard through my testing.

This is blocking me from writing accurate tests for UploadWizard, sadly, so I'd like to solve this problem soon.

Thanks!


Version: 1.20.x
Severity: major

Details

Reference
bz39771

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:49 AM
bzimport set Reference to bz39771.
bzimport added a subscriber: Unknown Object (MLST).

Sorry, clarification:

I'm only getting the plural version FROM THE SERVER. The {{PLURAL}} tag is never even stored on the client side when this bug occurs.

This bug appears to have been introduced by change I4950fdf8.

Bug was assigned to me, but I cannot see how or where in gerrir 20666 I could have broken this thing specifically. I'm unassigning, but working with Marc on IRC at the moment.

Caused by gerrit Ie349afa5. Niklas made a fix in gerrit Iee4e3bdc.

Confirmed fixed by reporter.