Page MenuHomePhabricator

Comments with the string "Gerrit 2.5" should not link to Gerrit.
Closed, ResolvedPublic


Currently, putting "G-errit 2.5" (minus the minus) in a comment causes a link to a Gerrit change id 2. This is kinda dumb, since the odds of someone actually referring to are almost zero.

Can we make the Gerrit regex in BZ a little less aggressive about linking to Gerrit? I'd like to at least be able to refer to the next version of the software without my comments being mauled.

Version: unspecified
Severity: normal



Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:10 AM
bzimport set Reference to bz41321.

Assuming that Gerrit version 10 is not around the corner,

match => qr{\bgerrit(\ change(set)?)?\ ?\#?(\d+)}i,

should be replaced by

match => qr{\bgerrit(\ change(set)?)?\ ?\#?(\d{2,})}i,

I'll cook up a Gerrit patch once my other one got in.

Obviously it's working (see subject of this report) so also verifying.