Maniphest T45221

invalid XML response ("4::olduser", "5::newuser", "6::edits" appears as node attributes)
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Bianjiang
	Dec 18 2012, 6:13 AM

Tags

Referenced Files

None

Subscribers

Description

The following api request got invalid XML content:

http://en.wikipedia.org/w/api.php?action=query&format=xml&list=recentchanges&rclimit=90&rcnamespace=0%7C2%7C4%7C6%7C10%7C14%7C100&rcprop=comment%7Cflags%7Cids%7Cloginfo%7Csizes%7Ctimestamp%7Ctitle%7Cuser&rcstart=2012-12-18T04:55:35Z

After splitting the response by ">", the buggy line is ~line108, where "4::olduser", "5::newuser", "6::edits" are invalid XML attributes.

<rc type="log" ns="2" title="User:Nikolaepa78" rcid="544675367" pageid="0" revid="0" old_revid="0" user="MBisanz" oldlen="0" newlen="0" timestamp="2012-12-18T04:54:36Z" comment="WP:CHU" logid="46399621" logtype="renameuser" logaction="renameuser" 4::olduser="Nikolaepa78" 5::newuser="Rgsseht" 6::edits="2" />
109 <rc type="edit" ns="0" title="Habítame Siempre" rcid="544675366" pageid="37430287" revid="528587893" old_revid="528474089" user="184.189.232.69" anon="" oldlen="29870" newlen="29871" ti mestamp="2012-12-18T04:54:35Z" comment="/* Weekly charts */ " />

similar bug happened before: https://bugzilla.wikimedia.org/show_bug.cgi?id=40299

Version: 1.21.x
Severity: critical

Details

Reference: bz43221

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 12:53 AM

• bzimport added a project: MediaWiki-Action-API.

• bzimport set Reference to bz43221.

• bzimport added a subscriber: Unknown Object (MLST).

Bianjiang created this task.Dec 18 2012, 6:13 AM

The bug also appears on commons.wikimedia.org:

http://commons.wikimedia.org/w/api.php?action=query&format=xml&list=recentchanges&rclimit=339&rcnamespace=0%7C2%7C4%7C6%7C10%7C14&rcprop=comment%7Cflags%7Cids%7Cloginfo%7Csizes%7Ctimestamp%7Ctitle%7Cuser&rcstart=2012-12-18T15:38:50Z

<rc type="log" ns="2" title="User:Der Kreole" rcid="86419746" pageid="4497688" revid="0" old_revid="0" user="EugeneZelenko" oldlen="0" newlen="0" timestamp="2012-12-18T15:26:07Z" comment="Request on [[Commons:Changing username]]" logid="51572035" logtype="renameuser" logaction="renameuser" 4::olduser="Der Kreole" 5::newuser="Ucevista" 6::edits="69" />

The problem is that the format of keys for log entry parameters was changed, such that we can't use them directly as XML attribute names.

Determining the best fix may require some discussion; I've posted[1] an RFC to the mediawiki-api mailing list.

[1]: http://lists.wikimedia.org/pipermail/mediawiki-api/2012-December/002776.html

https://gerrit.wikimedia.org/r/39221 will fix this particular bug.

(No. 2 of Brad Jorsch's suggestion)

Change merged.

do you need to clean-up any "cache"?

http://en.wikipedia.org/w/api.php?action=query&format=xml&list=recentchanges&rclimit=90&rcnamespace=0%7C2%7C4%7C6%7C10%7C14%7C100&rcprop=comment%7Cflags%7Cids%7Cloginfo%7Csizes%7Ctimestamp%7Ctitle%7Cuser&rcstart=2012-12-18T04:55:35Z

still broken.

It takes some time till software changes get deployed. This one will go live on January 7 on enwiki AFAIR

Resolved fixed means it's been fixed in the development version of MediaWiki. That doesn't mean Wikimedia have updated their live copy to it.

The change should be in 1.21wmf7. See https://www.mediawiki.org/wiki/MediaWiki_1.21/Roadmap for the schedule for deploying that to various wikis; it is currently scheduled for January 9 for enwiki.

Bug 43455 has been marked as a duplicate of this bug. ***

Aklapper removed subscribers: Anomie, • wikibugs-l-list.Oct 16 2020, 5:41 PM