Page MenuHomePhabricator

Implement "Templates used on this page" collapsing below edit window and the rest of Vector's footercleanup module in core
Closed, ResolvedPublic

Description

Currently on the English Wikipedia using the Vector skin, the list of templates used on a page that's available below the edit window is collapsed using JavaScript (e.g., https://en.wikipedia.org/w/index.php?title=Main_Page&action=edit). This enhancement should be available on other Wikimedia wikis.


Version: 1.21.x
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=45992

Details

Reference
bz43689

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:24 AM
bzimport set Reference to bz43689.

<div class="templatesUsed"><div class="mw-templatesUsedExplanation"><p><span id="templatesused">Pages <a href="/wiki/Wikipedia:Transclusion" title="Wikipedia:Transclusion">transcluded</a> onto the current version of this page:</span>
</p></div>

Reappropriating this bug slightly – let's just implement it on core.

Also taking this bug. I'll try to do this soon-ish, shouldn't be too much work.

So I discovered that doing this properly will require some more work.

Mostly, I'd like to avoid copying over the $.footerCollapsibleList module and use $.makeCollapsible from core.

This will require adding some hooks to it in order to provide the cookie persistence support $.footerCollapsibleList provides in the footer cleanup implementation itself.

When trying to do this, and discovered that $.makeCollapsible sucks more than I anticipated. I started submitting related patches to gerrit under the 'footer-cleanup-bug-43689' topic branch in mediawiki/master: https://gerrit.wikimedia.org/r/#/q/project:mediawiki/core+topic:footer-cleanup-bug-43689,n,z

This is currently part of the Vector extension. The Vector extension, like the WikiEditor extension, has lots of standlone experimental features that are mostly disabled by default.

It is only visible on English Wikipedia because it was decided to enable this particular one (ext.vector.footerCleanup) there.

Other wikis can do the same, there is no software change required for that. So unless there are local hacks I don't know about this is a duplicate of bug 45051.

If we want it on other wikis sooner (since bug 45051 will likely make it the default in core) a request on Meta could be made to make it the default on Wikipedia or all WMF projects, or request on local village pumps and put it on Wikimedia > Site requests.

Marking this bug duplicate of bug 45051 and assuming that it was incorrectly mistaken for an en.wikipedia hack.

The software changes Bartosz look interesting but are otherwise unrelated to this bug, Vector isn't even using that module.

  • This bug has been marked as a duplicate of bug 45051 ***

See bug 45946, for example, which requests it for commonswiki.

This blocks 45051. It's not a duplicate.

(In reply to comment #3)

Mostly, I'd like to avoid copying over the $.footerCollapsibleList module and
use $.makeCollapsible from core.

Yes, please! That is what I suggested when this first arrived on English Wikipedia.[1]

[1] https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)/Archive_104#Upcoming_changes_to_the_edit_window_.28please_read.29

I submitted a lot of commits to make $.makeCollapsible itself more bearable, then a few more to make it more useful, then a partial draft of this reimplementation: 72e8ae60dbc. This particular change will include only the collapsible lists; I'll implement the general restyling separately (as it'll be much more straightforward, mostly just copying over the CSS).

I91a3704c, that is, I copied the wrong hash.

Related URL: https://gerrit.wikimedia.org/r/65987 (Gerrit Change I756927b3f25f8fe701b74cb664653d3930cf7660)

Change 54089 merged by jenkins-bot:
Make the templates/category lists on edit page collapsible

https://gerrit.wikimedia.org/r/54089

Change 65987 merged by jenkins-bot:
Move jquery.footerCollapsibleList to core

https://gerrit.wikimedia.org/r/65987

Hooray, the largest and hairiest part is now done. Now let's move the styles for the edit form's footer – I'll submit a few patches to do that in a while.

Change 76067 had a related patch set uploaded by Matmarex:
mediawiki.action.edit: Add styles for edit form's footer

https://gerrit.wikimedia.org/r/76067

Change 76068 had a related patch set uploaded by Matmarex:
EditPage: Wrap the pipe between "Cancel" and "Editing help" links in a <span>

https://gerrit.wikimedia.org/r/76068

Change 76069 had a related patch set uploaded by Matmarex:
Hide MediaWiki's "Editing help" link, as we provide it in the toolbar

https://gerrit.wikimedia.org/r/76069

Change 76070 had a related patch set uploaded by Matmarex:
Delete the ext.vector.footerCleanup module

https://gerrit.wikimedia.org/r/76070

These four changes complete the migration.

Change 76067 merged by TheDJ:
mediawiki.action.edit: Add styles for edit form's footer

https://gerrit.wikimedia.org/r/76067

Change 76068 merged by TheDJ:
EditPage: Wrap the pipe between "Cancel" and "Editing help" links in a <span>

https://gerrit.wikimedia.org/r/76068

Change 76069 merged by jenkins-bot:
Hide MediaWiki's "Editing help" link, as we provide it in the toolbar

https://gerrit.wikimedia.org/r/76069

Change 76070 merged by jenkins-bot:
Delete the ext.vector.footerCleanup module

https://gerrit.wikimedia.org/r/76070

This is done now! Hooray!