Page MenuHomePhabricator

"ext_ref" field should be hidden/non-editable when submitting a task
Closed, ResolvedPublic

Description

There is an "ext_ref" blank field that all users can see when creating a task. It shouldn't be there.

Also, in existing tasks with a value (those that were imported from lab) the field is editable! It shouldn't be either.

See https://secure.phabricator.com/T6114 for possible solutions

Event Timeline

Qgil raised the priority of this task from to Needs Triage.
Qgil updated the task description. (Show Details)
Qgil changed Security from none to None.
Qgil subscribed.
Qgil renamed this task from "ext_ref" blank field when submitting a task to "ext_ref" blank field when submitting a task, is editable too.Sep 18 2014, 8:32 AM
Qgil updated the task description. (Show Details)

So according to https://secure.phabricator.com/book/phabricator/article/custom_fields/, if I get it right, "external_reference" on https://phabricator.wikimedia.org/config/edit/maniphest.custom-field-definitions/ should additionally have:

  • "edit" : false,
  • "view" : false,
  • "search" : true,
Aklapper renamed this task from "ext_ref" blank field when submitting a task, is editable too to "ext_ref" field should be hidden/non-editable when submitting a task.Sep 18 2014, 4:19 PM

...in operations/puppet under /modules/phabricator/data/fixed_settings.yaml

Aklapper triaged this task as Medium priority.Sep 18 2014, 4:26 PM

Also, can we call it "Reference" and remove the legend "external reference identifier"?

Qgil raised the priority of this task from Medium to High.Sep 21 2014, 3:58 PM

High priority because this task is blocking the opening of the registration to all wikimedians.

How is this blocking the opening? Don't see that.

Do we want users starting to modify those values?

Just to clarify, I proposed to hide this field when creating the task. Now appears as a confusing empty field (that is not meant to be filled manually ever).

Displaying it is fine for now, but it shouldn't be editable. Calling it "Reference" is also good.

chasemp claimed this task.

Field doesn't show up for new tasks, doesn't show up to edit for existing tasks, can still be searched for, and can still be seen for now. I am closing this and further refinement can be handled down the road. This situation will have to persist for some time.

Very well! Could you rename the field to "Reference"? The geekiness of "ext_ref" was one of the comments we got in the hangout last week.

I'm indifferent other than text length sanity for UI

It's a field that eventually will go. "Reference" is shorter and so neutral that is even boring (which in this case is good, the user attention should be elsewhere). This is also Chad's initial request/proposal. Let's just go for this.

I'm also indifferent, so 'Reference' would be ok

"ext_ref: $RANDOM_STRING" on tasks is ugly, why is this shown on tasks? If it must be shown, make "ext_ref" a link to something which explains the field, as we do with bugzilla fields.

Ah, sorry, now I see that it was closed for not showing up new tasks. Fair enough, will create new task.

chasemp mentioned this in Unknown Object (Diffusion Commit).Nov 15 2014, 1:01 AM
chasemp mentioned this in Unknown Object (Diffusion Commit).Dec 10 2014, 8:37 PM