Page MenuHomePhabricator

files from UIDGenerator not deleted after test run
Closed, ResolvedPublic

Description

Running phpunit leaves the following files in the tmp dir:

mw-UIDGenerator-UID-88
mw-UIDGenerator-UID-128
mw-UIDGenerator-UID-nodeid

Should be deleted automatically by UIDGenerator or the test


Version: 1.21.x
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=53791

Details

Reference
bz44850

Event Timeline

bzimport raised the priority of this task from to Low.
bzimport set Reference to bz44850.
bzimport added a subscriber: Unknown Object (MLST).

The same thing can happen after running maintenance/update.php, see bug 53791.

bd808 added a comment.Mar 27 2014, 8:43 PM

Leaving the files on disk seems to be intended behavior of the UIDGenerator class. It uses these files to store counter state and as an inter-process lock when creating timestamp based UUID variants.

Adding a cleanup to the test should be possible.

Change 121548 had a related patch set uploaded by BryanDavis:
Delete UIDGenerator cache files after unit tests

https://gerrit.wikimedia.org/r/121548

Change 121548 merged by jenkins-bot:
Delete UIDGenerator cache files after unit tests

https://gerrit.wikimedia.org/r/121548